| Summary: | rename "image URI" to something more obvious/clear | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] CloudForms Cloud Engine | Reporter: | wes hayutin <whayutin> | ||||||
| Component: | aeolus-conductor | Assignee: | Matt Wagner <matt.wagner> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Giulio Fidente <gfidente> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 1.0.0 | CC: | akarol, athomas, cpelland, deltacloud-maint, dmacpher, gfidente, hbrock, jtomasek, juwu, matt.wagner, mitch, morazi, psharma, redakkan, slinaber, ssachdev, tzumainn | ||||||
| Target Milestone: | beta2 | Keywords: | Triaged | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| URL: | https://qeblade31.rhq.lab.eng.bos.redhat.com/conductor/images/1d13d644-0d1b-4ff1-a506-241bdfbcdd51 | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | aeolus-conductor-0.13.11-1.el6cf | Doc Type: | Bug Fix | ||||||
| Doc Text: |
In Conductor, the 'Image URI' label was not clear to users. This bug fix renames 'Image URI' to 'Cloud Resource Provider's Image ID' so the labelling is clearer.
|
Story Points: | --- | ||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2012-12-04 14:55:46 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
There are countless ways you can say this. I assume "provider id" is not appropriate since that may confuse the content-type. Please consider the following: "id issued by provider" "id on provider" "provider specified id" "provider specific id" "id via provider" "provider delegated id" It doesn't look like string-length is an issue for the title as the id string is massive already. I'd favour "Provider's Image ID" From What I can tell we only need to alter this file:
/src/app/views/deployments/launch_from_catalog.html.haml:
36 %td=entry.hw_profile_for_image(image.id).architecture
37 %td
38: %h2 Deployable URI
39 %span=entry.url
40 %div.align-center
line 38: %h2 Deployable URI
to
%h2 Provider's Image ID
To change the "Image ID" string edit src/config/locales/en.yml specifically key en.deployments.launch_from_catalog.image_id Although the image_id related string is used multiple times through application. I could also find it it in src/app/views/images/_status.html.haml (where the screenshot comes from) This partial is used in image detail page. If we're changing "Image URI", I think the string we want is images.show.image_uri -- which is (thankfully) only shown in this one location. I will send out a pull request with a patch for this. https://github.com/aeolusproject/conductor/pull/36 should fix this. commit 9ae0616306f7c0def3dbeb52c702c71b5413d039
Author: Matt Wagner <matt.wagner>
Date: Tue Sep 4 15:39:30 2012 -0400
BZ 783128 - Renames "Image URI" to "Provider's Image ID"
Beyond the fact that it's not actually a URI at all, it's unclear
what it is. We decided "Provider's Image ID" was clearer.
https://bugzilla.redhat.com/show_bug.cgi?id=783128
(cherry picked from commit cdf39e1e1ae1ae665d7697cabfb0d3430a755be6)
in build aeolus-conductor-0.13.3-1.el6cf I am able to see "Image UUID" in place on "Image URI" and nowhere "Provider's Image ID".As far as i know about Conductor UI,"Image UUID" label is being used atleast from 1.0.This label makes perfect sense to me as well.But this is not what is expected in comment#7. Matt,Angus,Wes any change of mind? [root@dhcp201-113 ~]# rpm -qa|grep aeolus aeolus-conductor-doc-0.13.7-1.el6cf.noarch aeolus-all-0.13.7-1.el6cf.noarch rubygem-aeolus-cli-0.7.1-1.el6cf.noarch aeolus-configure-2.8.6-1.el6cf.noarch rubygem-aeolus-image-0.3.0-12.el6.noarch aeolus-conductor-0.13.7-1.el6cf.noarch aeolus-conductor-daemons-0.13.7-1.el6cf.noarch Created attachment 613856 [details]
image uuid
This is fallout from the upstream vs. product name thing. The "Image UUID" field is correct, and shouldn't be changed. It's properly a UUID identifying the image. The issue is with the second field. The second field should read "Provider's Image ID" upstream. We have a script to convert the upstream names to the ones requested for product, and this is where the insane "Cloud Resource Provider's Component Outline ID" string comes form. It converts "Provider" to "Cloud Resource Provider" and "Image" to "Component Outline". I don't know the right course of action here. The script is technically doing what PM wants with the names, but the result in this case is kind of insane and probably not what they intended. Perhaps "Cloud Resource Provider's Image ID"? I agree with Matt. Since this is the ID of an actual image, and not a Component Outline, having that in the title doesn't make sense. My vote is for ""Cloud Resource Provider's Image ID" We need to be careful with interchanging the term "Image" with "Component Outline". They are not interchangeable. The Component Outline is the receipe for building an image while the image is what was built from the Component Outline. I'm going to steal this task from Andy. I think the fix belongs in our translation script that I worked on with Angus. No sense in rotting Andy's brain with string changes. Patch on internal list (since it's just product names with no upstream benefit). Pushed to 1.1:
commit c88a61e903bc32af1166283d1cc67a22c7a8eab3
Author: Matt Wagner <matt.wagner>
Date: Tue Sep 18 16:46:22 2012 -0400
The automatic conversion from upstream to product names was
butchering a few phrases. I added a fixup section to our little
aeolus-translate.rb section and put in the two ones we've found
so far.
Should fix:
https://bugzilla.redhat.com/show_bug.cgi?id=783128 and
https://bugzilla.redhat.com/show_bug.cgi?id=857827
Signed-off-by: Tzu-Mainn Chen <tzumainn>
*** Bug 857899 has been marked as a duplicate of this bug. *** flipping this to ON_QA since it is attached to ET and the fix is in the latest brew build. the line 'Cloud Resource Provider's Image ID ' is displayed when using aeolus-conductor-0.13.14-1.el6cf Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2012-1516.html |
Created attachment 556271 [details] ss Description of problem: We thought image URI was not clear enough to the user. Although I dont think we came up w/ a better idea. The intent is to make it clear that this "id" comes from the provider itself. I want to convey that info w/o using "provider id" see screenshot