Bug 783142

Summary: inconsistent UX in wallaby shell CRUD commands
Product: Red Hat Enterprise MRG Reporter: Lubos Trilety <ltrilety>
Component: wallabyAssignee: Robert Rati <rrati>
Status: CLOSED NOTABUG QA Contact: MRG Quality Engineering <mrgqe-bugs>
Severity: low Docs Contact:
Priority: low    
Version: DevelopmentCC: iboverma, matt, willb
Target Milestone: 2.2   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 786166 786169 786173 (view as bug list) Environment:
Last Closed: 2012-02-07 20:01:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 786166, 786169, 786173    
Bug Blocks:    

Description Lubos Trilety 2012-01-19 14:10:25 UTC
Description of problem:
In wallaby shell commands there are some discrepancies (probably there could be more, then those mentioned below):

a) default value for parameters differs in various commands (add-params-to-node/group uses "0" but add-params-to-feature uses "" as default value)
# wallaby add-params-to-feature F P1
Console Connection Established...
# wallaby show-feature F
Console Connection Established...
F
  name:  "F"
  params:  {"P1"=>""}
  depends:  ["DF1"]
  conflicts:  ["CF"]
  included_features:  ["IF1"]

# wallaby add-params-to-group g P1
Console Connection Established...
# wallaby show-group g
Console Connection Established...
Showing the following group: g
g
  name:  "g"
  membership:  ["n1", "n"]
  features:  ["F", "F1", "F2"]
  params:  {"P1"=>"0"}


b) output from 'show=something' commands differs based on required type. 'show-group(subsystem)' has following redundant line.
"Showing the following group(subsystem):  "
Others (feature, node and parameters) don't print such line.

c) there is no need for 'modify-group', 'modify-feature' commands, they can change only names. There is no such commands for node, subsystem (for parameters there is 'modify-param' but it cannot change name)


Version-Release number of selected component (if applicable):
wallaby-utils-0.12.5-1

How reproducible:
100%

Steps to Reproduce:
see description
  
Actual results:


Expected results:
the behaviour and output will be unified for all similar wallaby commands

Additional info:

Comment 1 Will Benton 2012-01-24 15:40:18 UTC
This should probably be split into multiple bugs, some of which will wind up WONTFIX; assigning to Rob since these commands are his wheelhouse.

Comment 3 Will Benton 2012-02-07 20:01:15 UTC
The issues raised by this BZ have been split out into the following two bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=786166
https://bugzilla.redhat.com/show_bug.cgi?id=786169

Closing this one now.