Bug 783151
| Summary: | Review Request: FlightCrew - EPUB validation library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dan, notting, package-review |
| Target Milestone: | --- | Flags: | dan:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-31 21:50:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 772362 | ||
|
Description
Hans de Goede
2012-01-19 14:33:54 UTC
formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: 16afdb4fcb30275070907c27857f89930bd8a322 FlightCrew-0.7.2-Code.zip OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (LGPLv3+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A* %check is present and all tests pass. OK shared libraries are added to the regular linker search paths with scriptlet OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - rpmlint says FlightCrew.x86_64: W: spelling-error %description -l en_US epub -> pub, e pub FlightCrew.x86_64: W: spelling-error %description -l en_US validator -> lavatorial FlightCrew.x86_64: W: no-manual-page-for-binary flightcrew-cli FlightCrew.src: W: spelling-error %description -l en_US epub -> pub, e pub FlightCrew.src: W: spelling-error %description -l en_US validator -> lavatorial FlightCrew.src: W: invalid-url Source0: http://flightcrew.googlecode.com/files/FlightCrew-0.7.2-Code.zip HTTP Error 404: Not Found FlightCrew-devel.x86_64: W: no-documentation => nothing blocks the review - when googlemock is included in fedora, the test-suite could be built and run - in some future iteration the standalone gui validator could be also built The package is APPROVED. New Package SCM Request ======================= Package Name: FlightCrew Short Description: EPUB validation library Owners: jwrdegoede sharkcz Branches: f16 InitialCC: Danny, thanks for the review! Git done (by process-git-requests). FlightCrew has been imported and build for Rawhide and F-16. I don't intend to do a F-16 update in bodhi until we've the entire chain (ZipArchive, FlightCrew and Sigil) and then I'll push them all as one update -> closing. |