Bug 783168

Summary: Config Server hostname, key, and secret input values are not properly trimmed
Product: [Retired] CloudForms Cloud Engine Reporter: Greg Blomquist <gblomqui>
Component: aeolus-conductorAssignee: Tzu-Mainn Chen <tzumainn>
Status: CLOSED ERRATA QA Contact: wes hayutin <whayutin>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 1.0.0CC: akarol, athomas, deltacloud-maint, dgao, slinaber, ssachdev
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-05-15 22:17:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Greg Blomquist 2012-01-19 15:25:26 UTC
Description of problem:

When adding a config server to a provider account in Conductor, the hostname, key, and secret values are not trimmed on submit.  As a result, trailing (unseen) spaces in either of those fields results in a 401 error (or, potentially a 404 error, if the hostname field is the one with an extra space) when Conductor tries to authenticate against the config server with untrimmed values.

Steps to Reproduce:
1. In conductor, add a config server to a provider account
2. Enter a valid hostname, consumer key, and consumer secret in the text fields
3. Add an additional space at the end of the consumer key field
4. Click "Save"
  
Actual results:

Conductor reports that it cannot add the config server, because it received a 401 when attempting to authenticate.


Expected results:

Conductor should automatically trim the input values before saving and testing the connection to the config server.

Comment 1 Tzu-Mainn Chen 2012-01-25 19:28:12 UTC
Patch created:

https://fedorahosted.org/pipermail/aeolus-devel/2012-January/008357.html

Comment 2 Tzu-Mainn Chen 2012-01-25 20:35:28 UTC
Patch pushed to 1.0-staging:

commit d60e281a775cca84b05ba05308478a9e1d03ab36
BZ 783168 added whitespace trim to config_server parameters

Comment 3 Steve Linabery 2012-01-26 16:48:51 UTC
d60e281 in aeolus-conductor-0.8.0-12

Comment 5 Shveta 2012-01-31 13:38:22 UTC
Able to add "consumer key" with space also.

Verified in
 rpm -qa|grep aeolus
aeolus-conductor-doc-0.8.0-16.el6.noarch
aeolus-configure-2.5.0-11.el6.noarch
aeolus-conductor-daemons-0.8.0-16.el6.noarch
rubygem-aeolus-image-0.3.0-6.el6.noarch
aeolus-all-0.8.0-16.el6.noarch
aeolus-conductor-0.8.0-16.el6.noarch
rubygem-aeolus-cli-0.3.0-7.el6.noarch

Comment 6 errata-xmlrpc 2012-05-15 22:17:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2012-0583.html