Bug 783425

Summary: Getting account disable value as 'none' instead of 'false' after creating new user
Product: Red Hat Satellite Reporter: Sachin Ghai <sghai>
Component: APIAssignee: Tomas Strachota <tstrachota>
Status: CLOSED CURRENTRELEASE QA Contact: Katello QA List <katello-qa-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.0.0CC: bkearney
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: katello-cli-0.1.49-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-22 18:21:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 747354    

Description Sachin Ghai 2012-01-20 11:34:24 UTC
Description of problem:
By default, account "disable" option should be set as 'false'. However when I created a new user without explicitly setting --disabled option set this value to 'None' . I guess this should be a boolean value either true or false.

katello> user create --username testuser --password redhat --email testuser
Successfully created user [ testuser ]
katello> user list 
----------------------------------------------------------------------------
                                 User List

 Id   Username   Email                Disabled  
----------------------------------------------------------------------------
 1    admin      root@localhost       False     
 2    reader     sghai     False     
 3    testuser   testuser   None      



Help text says: default is 'false'.

katello> user create --help
Usage: katello [options]

Options:
  -h, --help           show this help message and exit
  -g                   grep friendly output
  -v                   verbose, more structured output
  -d DELIMITER         grep friendly output column delimiter
  --username=USERNAME  user name (required)
  --password=PASSWORD  initial password (required)
  --email=EMAIL        email (required)
  --disabled=DISABLED  disabled account (default is 'false')
katello> 


Version-Release number of selected component (if applicable):
[root@dhcp201-112 f15]# rpm -qa | grep -ie katello-0 -ie katello-cli
katello-cli-common-0.1.39-1.el6.noarch
katello-0.1.185-1.el6.noarch
katello-cli-0.1.39-1.el6.noarch
[root@dhcp201-112 f15]# 


How reproducible:
always

Steps to Reproduce:
1. create user from cli
2. user list
3.
  
Actual results:
getting account disable value as 'none' instead of 'false' after creating new user

Expected results:
By default, account "disable" option should be set as 'false' as per help text. 


Additional info:

Comment 1 Tomas Strachota 2012-01-30 14:25:59 UTC
Default value of option --disabled set to False in both user create and update.

Comment 2 Sachin Ghai 2012-02-02 11:25:36 UTC
Verified with following katello build:

katello-0.1.211-1.el6.noarch
katello-cli-0.1.49-1.el6.noarch


Default value is set to false:
=====================

katello> user create --username testuser --password redhat --email sghai 
Successfully created user [ testuser ]


katello> user list 
--------------------------------------------------------------------------
                                User List

 Id   Username   Email              Disabled  
--------------------------------------------------------------------------
 1    admin      root@localhost     False     
 2    testuser   sghai   False 


Update the disabled value from true:
===================================

katello> user create --username testuser1 --password redhat --email sghai --disabled=true
Successfully created user [ testuser1 ]


katello> user list 
--------------------------------------------------------------------------
                                User List

 Id   Username   Email              Disabled  
--------------------------------------------------------------------------
 1    admin      root@localhost     False     
 2    testuser   sghai   False     
 3    testuser1  sghai   True      


katello> user update --username testuser1 --password redhat --email sghai
Successfully updated user [ testuser1 ]
katello> user list 
--------------------------------------------------------------------------
                                User List

 Id   Username   Email              Disabled  
--------------------------------------------------------------------------
 1    admin      root@localhost     False     
 2    testuser   sghai   False     
 3    testuser1  sghai   False