Bug 783454

Summary:	Review Request: perl-URI-Title - Get the titles of things on the web in a sensible way
Product:	[Fedora] Fedora	Reporter:	Petr Šabata <psabata>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-URI-Title-1.85-1.fc17	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-01-24 12:00:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Petr Šabata 2012-01-20 13:41:57 UTC

Spec URL: http://psabata.fedorapeople.org/pkgs/perl-URI-Title/perl-URI-Title.spec
SRPM URL: http://psabata.fedorapeople.org/pkgs/perl-URI-Title/perl-URI-Title-1.85-1.fc16.src.rpm
Description:

I keep having to find the title of things on the web.  This
seems like a really simple request, just get() the object,
parse for a title tag, you're done.  Ha, I wish.  There are
several problems with this approach:

What if the resource is on a very slow server?  Do we wait
forever or what?
What if the resource is a 900 gig file?  You don't want to
download that.
What if the page title isn't in a title tag, but is buried
in the HTML somewhere?
What if the resource is an MP3 file, or a word document
or something?
...

So, let's solve these issues once.

Comment 1 Petr Pisar 2012-01-23 17:20:14 UTC

Source file is original. Ok.
Summary verified from lib/URI/Title.pm. Ok.
License verified from lib/URI/Title.pm. Ok.
URL and Source0 are alive. Ok.

Description verified from lib/URI/Title.pm. Ok.
TODO: Re-format the text to bigger width. Maybe you could remove the three dots.

No XS code, noarch BuildArch is Ok.

TODO: Build-require `perl(lib)' for tests (t/00bootstrap.t:3).

All test pass. Ok.

$ rpmlint  perl-URI-Title.spec ../SRPMS/perl-URI-Title-1.85-1.fc17.src.rpm ../RPMS/noarch/perl-URI-Title-1.85-1.fc17.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-URI-Title-1.85-1.fc17.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jan 23 17:59 /usr/share/doc/perl-URI-Title-1.85
-rw-r--r--    1 root    root                     2187 Jul 27  2009 /usr/share/doc/perl-URI-Title-1.85/Changes
-rw-r--r--    1 root    root                     2711 Jan 23 17:59 /usr/share/man/man3/URI::Title.3pm.gz
drwxr-xr-x    2 root    root                        0 Jan 23 17:59 /usr/share/perl5/vendor_perl/URI
drwxr-xr-x    2 root    root                        0 Jan 23 17:59 /usr/share/perl5/vendor_perl/URI/Title
-rw-r--r--    1 root    root                     6333 Jun  2  2011 /usr/share/perl5/vendor_perl/URI/Title.pm
-rw-r--r--    1 root    root                     2653 Feb 11  2011 /usr/share/perl5/vendor_perl/URI/Title/HTML.pm
-rw-r--r--    1 root    root                      386 Apr 21  2008 /usr/share/perl5/vendor_perl/URI/Title/Image.pm
-rw-r--r--    1 root    root                     1114 May  6  2004 /usr/share/perl5/vendor_perl/URI/Title/MP3.pm
-rw-r--r--    1 root    root                      989 May  6  2004 /usr/share/perl5/vendor_perl/URI/Title/PDF.pm
-rwxr-xr-x    1 root    root                      187 Mar 20  2006 /usr/share/perl5/vendor_perl/URI/title.pl
File permissions are Ok.

TODO: Move /usr/share/perl5/vendor_perl/URI/title.pl to /usr/bin or remove it or package it as documentation. The file is useless here.

$ rpm -q --requires -p ../RPMS/noarch/perl-URI-Title-1.85-1.fc17.noarch.rpm |sort | uniq -c
      1 perl(base)  
      1 perl(Carp)  
      1 perl(Encode)  
      1 perl(Exporter)  
      1 perl(File::Temp)  
      1 perl(File::Type) >= 0.22
      1 perl(HTML::Entities)  
      1 perl(HTTP::Request)  
      1 perl(HTTP::Response)  
      1 perl(Image::Size)  
      1 perl(lib)  
      1 perl(LWP::UserAgent)  
      1 perl(:MODULE_COMPAT_5.14.2)  
      1 perl(Module::Pluggable) >= 1.2
      1 perl(MP3::Info)  
      1 perl(strict)  
      1 perl(URI::Title)  
      1 perl(utf8)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 /usr/bin/perl  
Binary requires are Ok.

$ rpm -q --provides  -p ../RPMS/noarch/perl-URI-Title-1.85-1.fc17.noarch.rpm |sort | uniq -c
      1 perl(URI::Title) = 1.85
      1 perl-URI-Title = 1.85-1.fc17
      1 perl(URI::Title::HTML)  
      1 perl(URI::Title::Image)  
      1 perl(URI::Title::MP3)  
      1 perl(URI::Title::PDF)  
Binary provides are Ok.

$ resolvedeps rawhide  ../RPMS/noarch/perl-URI-Title-1.85-1.fc17.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3725932). ???

Otherwise package is in line with Fedora and Perl packaging guidelines.


Please consider fixing all `TODO' items before building this package.

Resolution: Package APPROVED.

Comment 2 Petr Šabata 2012-01-24 08:26:17 UTC

New Package SCM Request
=======================
Package Name: perl-URI-Title
Short Description: Get the titles of things on the web in a sensible way
Owners: psabata mmaslano ppisar
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2012-01-24 11:03:59 UTC

Git done (by process-git-requests).

Comment 4 Petr Šabata 2012-01-24 12:00:16 UTC

Thank you, guys.

TODOs fixed in the first build.