Bug 783554

Summary:	ipa delegation-mod --attrs= removes Attributes from delegation instead of failing
Product:	Red Hat Enterprise Linux 6	Reporter:	Scott Poore <spoore>
Component:	ipa	Assignee:	Rob Crittenden <rcritten>
Status:	CLOSED DUPLICATE	QA Contact:	IDM QE LIST <seceng-idm-qe-list>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.3	CC:	dpal, jgalipea, mkosek, pviktori
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-27 11:57:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Scott Poore 2012-01-20 20:06:42 UTC

Description of problem:

ipa delegation-mod is not failing when --attrs= is used with no value.  Instead it simply removes the Attribute entry from the delegation altogether.  I would have expected this to error out and not allow entering an empty attrs to delete it from the delegation.

# ipa delegation-find testdelegation
--------------------
1 delegation matched
--------------------
  Delegation name: testdelegation
  Permissions: write
  Attributes: mobile
  Member user group: dnegroup
  User group: ipausers
----------------------------
Number of entries returned 1
----------------------------

# ipa delegation-mod testdelegation --attrs=
------------------------------------
Modified delegation "testdelegation"
------------------------------------
  Delegation name: testdelegation
  Permissions: write
  Member user group: dnegroup
  User group: ipausers


Version-Release number of selected component (if applicable):

ipa-server-2.2.0-101.20120118T0229zgitbb854ce.el6.x86_64
ipa-admintools-2.2.0-101.20120118T0229zgitbb854ce.el6.x86_64
389-ds-base-libs-1.2.9.14-1.el6.x86_64
389-ds-base-1.2.9.14-1.el6.x86_64

How reproducible:

always

Steps to Reproduce:
1.  <setup ipa server>
2.  kinit admin
3.  ipa delegation-add testdelegation --membergroup=admins --group=ipausers --attrs=mobile
4.  ipa delegation-mod testdelegation --attrs=

  
Actual results:

Removes Attributes from Delegation.

------------------------------------
Modified delegation "testdelegation"
------------------------------------
  Delegation name: testdelegation
  Permissions: write
  Member user group: dnegroup
  User group: ipausers


Expected results:

Disallow this behavior and return a descriptive error message.

Additional info:

The same occurs for:

ipa delegation-mod testdelegation --attrs=""

and for:

ipa delegation-mod testdelegation --attrs=" "

Comment 2 Dmitri Pal 2012-01-20 23:19:17 UTC

Upstream ticket:
https://fedorahosted.org/freeipa/ticket/2297

Comment 3 Petr Viktorin 2012-02-27 11:57:23 UTC

Duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=782974 -- removing a required attribute through setting it to an empty string.

*** This bug has been marked as a duplicate of bug 782974 ***