| Summary: | Review Request:gmail-notify-ext - Gmail checker Gnome Online Accounts based | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Jabłoński <jablona123> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED CANTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade, pikachu.2014, sgordon |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-15 12:09:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Adam Jabłoński
2012-01-22 00:05:15 UTC
- Based on previous extensions that have been approved, consider renaming the package to fit the form gnome-shell-extension-*. - The license string is not recognised, see the following for a list of valid values. In this instance you possibly want GPLv2 or GPLv2+. http://fedoraproject.org/wiki/Licensing - Use the %find_lang macro for the locale files: http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files - This looks like a noarch package but is not marked as such: http://fedoraproject.org/wiki/Common_Rpmlint_issues#no-binary - Consider adding a README: http://fedoraproject.org/wiki/Common_Rpmlint_issues#no-documentation - Consider expanding the %description field, currently it contains less information than the Summary. Full rpmlint output: gmail-notify-ext.x86_64: W: invalid-license GPL2 gmail-notify-ext.x86_64: E: no-binary gmail-notify-ext.x86_64: W: no-documentation gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/it/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/nl/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/se/LC_MESSAGES/gmail_notify.mo 1 packages and 0 specfiles checked; 1 errors, 12 warnings. Note I'm not sponsored, so can't take this review request, but addressing the above may help expedite the review process when someone else does. *** Bug 785414 has been marked as a duplicate of this bug. *** Spec URL: http://dl.dropbox.com/u/47812293/gmail_notify/V3.5/gmail-notify-ext-0.3.5-1.spec SRPM URL: http://dl.dropbox.com/u/47812293/gmail_notify/V3.5/gmail-notify-ext-0.3.5-1.fc16.src.rpm Description: Updated Gnome 3 shell extension to check gmail accounts for new emails checker. Utilizes Gnome Online Accounts OAuth to connect to Gmail The license string issue has been corrected :). I can also see you also added an expanded description which is great, unfortunately though the lines in it are > 80 characters long, please ensure you put line breaks in the description field at or before 80 characters. Otherwise the issues I raised in c#1 still stand: - Use the %find_lang macro for the locale files: http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files - This looks like a noarch package but is not marked as such: http://fedoraproject.org/wiki/Common_Rpmlint_issues#no-binary The following additional issues appear to have been introduced because upstream have added a Greek translation but it is using the wrong locale (el instead of gr): gmail-notify-ext.x86_64: E: incorrect-locale-el /usr/share/locale/gr/LC_MESSAGES gmail-notify-ext.x86_64: E: invalid-lc-messages-dir /usr/share/locale/gr/LC_MESSAGES/gmail_notify.mo See http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-locale-el Adam: are you an approved packager? I can't find you in the Fedora Account System. (In reply to comment #5) > Adam: are you an approved packager? I can't find you in the Fedora Account > System. Nope, I'm kind of newbe in packaging :) Just authored one extension for gnome shell and wanted to share it with fedora people (In reply to comment #6) > Nope, I'm kind of newbe in packaging :) Just authored one extension for gnome > shell and wanted to share it with fedora people OK, I just set the FE-NEEDSPONSOR blocker. You probably already read the following page: http://fedoraproject.org/wiki/Join_the_package_collection_maintainers http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group So improve your package(s) according to the guidelines and the advices given by other packages, read other open review requests and don't hesitate to contribute to some of them ;). Hope you'll be soon approved. Removing FE-NEEDSPONSOR from the closed review tickets. |