Bug 783778
| Summary: | Review Request: libgta - Library that implements the Generic Tagged Arrays file format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Volker Fröhlich <volker27> |
| Component: | Package Review | Assignee: | Joonas Sarajärvi <muep> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | muep, notting, package-review |
| Target Milestone: | --- | Flags: | muep:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libgta-1.0.2-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-15 23:54:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Volker Fröhlich
2012-01-22 13:58:19 UTC
Spec URL: http://www.geofrogger.net/review/libgta.spec SRPM URL: http://www.geofrogger.net/review/libgta-1.0.2-1.fc16.src.rpm * Thu Jan 28 2012 Volker Fröhlich <volker27> 1.0.2-1 - New upstream release - Remove DESTDIR correction for install-exec-hook (now upstream) Review for libgta-1.0.2-1
Rpmlint output:
$ rpmlint SPECS/libgta.spec SRPMS/libgta-1.0.2-1.fc16.src.rpm RPMS/x86_64/libgta-*.rpm
libgta.src: I: enchant-dictionary-not-found en_US 4 packages and 1 specfiles checked; 0 errors, 0 warnings.
| MUST Item | Comments |
|-----------------------------------------+----------|
| Package name | OK |
| Spec file name | OK |
| Packaging guidelines | OK |
| Licensing | OK |
| License match | OK |
| License file in %doc | OK |
| Spec file English | OK |
| Spec file legibilty | OK |
| Source archive md5 | OK [1] |
| Builds on primary archs | OK [2] |
| Build dependencies | OK [3] |
| Locales | OK |
| ldconfig calls in %post, %postun | OK |
| No copies of system libraries | OK |
| Relocatability | OK |
| Owns all created dirs | OK |
| %files item unqueness | OK |
| File permissions | OK |
| Macro use consitence | OK |
| Code or permissible content | OK |
| Large docs in -doc subpackage | OK [4] |
| %doc contents do not affect use | OK |
| Header files in -devel subpkg | OK |
| Static libs in -static subpkg | OK |
| .so symlink in -devel subpkg | OK |
| -devel requires base package | OK |
| No libtool archives | OK |
| .desktop file if needed | OK |
| other packages' files or dirs not owned | OK |
| All filesnames are UTF-8 | OK |
|-----------------------------------------+----------|
| SHOULD item | Comments |
|-----------------------------------------+----------|
| License text request | OK |
| Translations of description and summary | none |
| Package builds in mock | OK |
| Builds on all primary archs | OK |
| Package functions as described | OK [5] |
| Scriptlets are sane | OK |
| Subpackage deps on base package | OK |
| pkgconfig file placement | OK |
| prefer package deps over file deps | OK |
| man pages for binaries/scriprs | OK |
Notes:
[1] Md5 sum: 921566669683385f295bb6f21d5dedee.
[2] Builds both on x86_64 and i386.
[3] Builds in mock.
[4] Reference documentation takes 1.7 megabytes. I do not feel
it is big enough to block the review, but would myself
prefer having them and the examples in a -doc subpkg.
[5] All the shipped example programs can be built. Did not test
if the library actually works as described.
New Package SCM Request ======================= Package Name: libgta Short Description: Library that implements the Generic Tagged Arrays file format Owners: volter Branches: f15 f16 el6 InitialCC: Git done (by process-git-requests). Thank you for the review, Joonas! I only looked at the size of the rpm file, therefore I didn't notice the documentation is actually 1,7 MB. I added a doc sub-package. libgta-1.0.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libgta-1.0.2-2.fc15 libgta-1.0.2-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libgta-1.0.2-2.fc16 libgta-1.0.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libgta-1.0.2-2.el6 libgta-1.0.2-2.el6 has been pushed to the Fedora EPEL 6 testing repository. libgta-1.0.2-2.fc16 has been pushed to the Fedora 16 stable repository. libgta-1.0.2-2.fc15 has been pushed to the Fedora 15 stable repository. libgta-1.0.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |