| Summary: | Review Request: perl-HTTP-ProxyAutoConfig - Use a .pac or wpad.dat file to get proxy information | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šabata <psabata> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mmraka, notting, package-review, ppisar, xavier |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-HTTP-ProxyAutoConfig-0.3-1.fc17 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-26 13:19:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Petr Šabata
2012-01-23 16:30:01 UTC
Source file is original. Ok. URL and Source0 are alive. Ok. Summary verified from lib/HTTP/ProxyAutoConfig.pm. Ok. FIX: Change license to `GPLv2+ or Artistic' or clarify with upstream. lib/HTTP/ProxyAutoConfig.pm says: > This module is free software; you may redistribute it and/or modify it > under the same terms as Perl 5.10.1. For more details, see the full > text of the licenses at > <http://www.perlfoundation.org/artistic_license_1_0> and > http://www.gnu.org/licenses/gpl-2.0.html > <http://www.gnu.org/licenses/gpl-2.0.html> Description verified from lib/HTTP/ProxyAutoConfig.pm. Ok. All tests require network access witch is not available in Koji. Conditionally disabled by default Ok. $ rpmlint perl-HTTP-ProxyAutoConfig.spec ../SRPMS/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.src.rpm ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) wpad -> woad, wad, pad perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) dat -> DAT, tad, sat perl-HTTP-ProxyAutoConfig.src: W: spelling-error %description -l en_US pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) wpad -> woad, wad, pad perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) dat -> DAT, tad, sat perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error %description -l en_US pac -> PAC, cap, pa 2 packages and 1 specfiles checked; 0 errors, 8 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm drwxr-xr-x 2 root root 0 Jan 24 09:57 /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3 -rw-r--r-- 1 root root 1257 Mar 26 2010 /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3/Changes -rw-r--r-- 1 root root 2382 Mar 14 2010 /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3/README drwxr-xr-x 2 root root 0 Jan 24 09:57 /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3/examples -rwxr-xr-x 1 root root 284 May 25 2001 /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3/examples/auto_proxy.pl -rw-r--r-- 1 root root 3440 Jan 24 09:57 /usr/share/man/man3/HTTP::ProxyAutoConfig.3pm.gz drwxr-xr-x 2 root root 0 Jan 24 09:57 /usr/share/perl5/vendor_perl/HTTP -rw-r--r-- 1 root root 23760 Mar 26 2010 /usr/share/perl5/vendor_perl/HTTP/ProxyAutoConfig.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(IO::Socket) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(Sys::Hostname) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. Documentation does not push new dependencies. Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm | sort | uniq -c 1 perl(HTTP::ProxyAutoConfig) = 0.3 1 perl-HTTP-ProxyAutoConfig = 0.3-1.fc17 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3728249). ??? Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed issues and provide new spec file. Resolution: Package NOT approved. The only mention of GPL2 is the link but I've asked upstream for clarification anyway. Upstream confirms the GPL+ or Artistic is correct. I've included the 'LICENSE.correspondence' file in %doc. Updated package is on the same URLs. Spec file changes: --- perl-HTTP-ProxyAutoConfig.spec.old 2012-01-23 17:28:04.000000000 +0100 +++ perl-HTTP-ProxyAutoConfig.spec 2012-01-26 09:38:57.095000001 +0100 @@ -6,6 +6,7 @@ Group: Development/Libraries URL: http://search.cpan.org/dist/HTTP-ProxyAutoConfig/ Source0: http://www.cpan.org/authors/id/M/MA/MACKENNA/HTTP-ProxyAutoConfig-%{version}.tar.gz +Source1: LICENSE.correspondence BuildArch: noarch BuildRequires: perl(ExtUtils::MakeMaker) >= 6.56 %{?_with_network_tests: @@ -26,6 +27,7 @@ %prep %setup -q -n HTTP-ProxyAutoConfig-%{version} +cp %{SOURCE1} . %build %{__perl} Makefile.PL INSTALLDIRS=vendor @@ -42,7 +44,7 @@ %{?_with_network_tests: make test} %files -%doc Changes examples README +%doc Changes examples README LICENSE.correspondence %{perl_vendorlib}/* %{_mandir}/man3/* > FIX: Change license to `GPLv2+ or Artistic' or clarify with upstream. Upstream confirmed the correct license is GPLv1+ or Artistic. Ok. $ rpmlint perl-HTTP-ProxyAutoConfig.spec ../SRPMS/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.src.rpm ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) wpad -> woad, wad, pad perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) dat -> DAT, tad, sat perl-HTTP-ProxyAutoConfig.src: W: spelling-error %description -l en_US pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.src: W: strange-permission LICENSE.correspondence 0600L perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) wpad -> woad, wad, pad perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) dat -> DAT, tad, sat perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error %description -l en_US pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.noarch: E: non-readable /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3/LICENSE.correspondence 0600L 2 packages and 1 specfiles checked; 1 errors, 9 warnings. TODO: Change LICENSE.correspondence mode to 0644. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3733971). Ok. Please correct all `TODO' items before building this package. Resolution: Package APPROVED. New Package SCM Request ======================= Package Name: perl-HTTP-ProxyAutoConfig Short Description: Use a .pac or wpad.dat file to get proxy information Owners: psabata mmaslano ppisar Branches: InitialCC: perl-sig Git done (by process-git-requests). Thank you, both. I corrected the LICENSE.correspondence permissions to 0644 before the import. Package Change Request ====================== Package Name: perl-HTTP-ProxyAutoConfig New Branches: epel7 Owners: xavierb mmraka Petr is not interested in an epel7 branch and agreed that I request a branch. See https://bugzilla.redhat.com/show_bug.cgi?id=1139399 Git done (by process-git-requests). |