Bug 784075

Summary:

[PATCH] tar extraction fails when the Drag'n'Drop target path contains spaces

Product:

[Fedora] Fedora

Reporter:

Jaromír Cápík <jcapik>

Component:

xarchiver

Assignee:

Jaromír Cápík <jcapik>

Status:

CLOSED ERRATA

QA Contact:

Fedora Extras Quality Assurance <extras-qa>

Severity:

unspecified

Docs Contact:

Priority:

unspecified

Version:

rawhide

CC:

cwickert, ovasik

Target Milestone:

---

Target Release:

---

Hardware:

Unspecified

OS:

Unspecified

Whiteboard:

Fixed In Version:

xarchiver-0.5.2-13.fc16

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2012-03-01 09:31:55 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Attachments:

Description	Flags
xarchiver-0.5.2-whitespaces_in_path.patch	none
xarchiver-0.5.2-drag-n-drop_escaped_path.patch	none
xarchiver-0.5.2-drag-n-drop_escaped_path.patch	none

Description Jaromír Cápík 2012-01-23 18:34:49 UTC

Description of problem:
When I try to drag files from tar archives opened with Xarchiver and drop them to a directory containing spaces in the path, the extraction fails, since the tar command is missing quotation marks.
The attached patch solves the issue.

Version-Release number of selected component (if applicable):
0.5.2-11

Comment 1 Jaromír Cápík 2012-01-23 18:36:01 UTC

Created attachment 557022 [details]
xarchiver-0.5.2-whitespaces_in_path.patch

Comment 2 Jaromír Cápík 2012-01-23 19:15:59 UTC

Created attachment 557036 [details]
xarchiver-0.5.2-drag-n-drop_escaped_path.patch

The following patch fixes the issue better ... works for all characters which need to be escaped ...

Comment 3 Jaromír Cápík 2012-01-23 19:48:34 UTC

Created attachment 557050 [details]
xarchiver-0.5.2-drag-n-drop_escaped_path.patch

The previous one could produce unwanted memory leaks by leaving the original unescaped path unfreed.

Comment 4 Christoph Wickert 2012-01-24 15:06:27 UTC

Thanks for the patch. I have just given you commit access, so you can check this in yourself. Please make sure to add useful comments in the spec and issue updates as necessary and let the close this bug.

Comment 5 Jaromír Cápík 2012-01-26 11:39:10 UTC

Ok .... thank You. Gonna do that.

Comment 6 Fedora Update System 2012-01-26 13:11:13 UTC

xarchiver-0.5.2-13.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/xarchiver-0.5.2-13.fc16

Comment 7 Fedora Update System 2012-01-26 13:13:35 UTC

xarchiver-0.5.2-13.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/xarchiver-0.5.2-13.fc15

Comment 8 Fedora Update System 2012-01-26 22:54:31 UTC

Package xarchiver-0.5.2-13.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing xarchiver-0.5.2-13.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-0948/xarchiver-0.5.2-13.fc16
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2012-03-01 09:31:55 UTC

xarchiver-0.5.2-13.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2012-03-01 09:35:08 UTC

xarchiver-0.5.2-13.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.