Bug 784079
| Summary: | hg view is broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Andy Grover <agrover> | ||||
| Component: | mercurial | Assignee: | Petr Stodulka <pstodulk> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Leos Pol <lpol> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 6.2 | CC: | ahughes, davejohansen, lpol, ovasik, rda, tlavigne | ||||
| Target Milestone: | rc | Keywords: | EasyFix, Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | mercurial-1.4-4.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | * Previously, the "hg view" command failed with the "Permission denied" error message. This update adds the required execute permission to the hgk utility. As a result, running "hg view" works as expected. (BZ#784079) | Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-07-22 07:45:36 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: | 
 | ||||||
| 
        
          Description
        
        
          Andy Grover
        
        
        
        
        
          2012-01-23 18:40:59 UTC
        
       permissions on /usr/libexec/mercurial and /usr/libexec/mercurial/hgk need to be +x. This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. If you would like it considered as an exception in the current release, please ask your support representative. Created attachment 952773 [details]
Fix permissions of hgk
This patch fixes the issue in this bugzilla, so can it please be applied and an updated version of mercurial be released?
The problem is obvious from listing the the rpm contents: rpm -qlvp mercurial-hgk-1.4-3.el6.x86_64.rpm -rw-r--r-- 1 root root 118 Mar 12 2010 /etc/mercurial/hgrc.d/hgk.rc -rw-r--r-- 1 root root 11698 Nov 16 2009 /usr/lib64/python2.6/site-packages/hgext/hgk.py -rw-r--r-- 1 root root 10826 Mar 12 2010 /usr/lib64/python2.6/site-packages/hgext/hgk.pyc -rw-r--r-- 1 root root 10780 Mar 12 2010 /usr/lib64/python2.6/site-packages/hgext/hgk.pyo drw-r--r-- 2 root root 0 Mar 12 2010 /usr/libexec/mercurial -rw-r--r-- 1 root root 109044 Mar 12 2010 /usr/libexec/mercurial/hgk A directory that doesn't have execute permission can't function as a directory. I've tested Dave's patch and it works. The issue is an obvious error in the mercurial packaging, not the code itself. Please fix and re-release the package. I agree. It seems like candidate for fasttrack. Any update on this being applied? Hi Dave, I hope that patch will be aplied in rhel-6.8. Just hit this myself today. Given this has PM+dev ACKs, it could go out for RHEL 6.7 with the requisite QA ack added. At present, hg view is completely broken as shipped. The test and fix is very simple. 1. $ hg clone http://hg.openjdk.java.net/jdk8u/jdk8u 2. $ cd jdk8u 3. $ hg view Current result: /bin/sh: /usr/libexec/mercurial/hgk: Permission denied Expected result: hgk loads up, displaying a graphical view of the repository. Fix: Making /usr/libexec/mercurial and /usr/libexec/mercurial/hgk executable. I tested this fix manually by doing the following as root: $ chmod ugo+X /usr/libexec/mercurial $ chmod ugo+x /usr/libexec/mercurial/hgk and hgk then loads. Yes, it's expected solution according to proposed patch :-) Was the patch sufficient? I found that it only worked if hgk itself was also made executable. Yes, it is. Because hgk inherit permissions from directory. Ok, so the RPM change also makes hgk executable? That's fine. The patch works - we've been rebuilding/installing a patched mercurial rpm for over 3 years now. It would be great if Redhat would correct their packaging error and release an update. # rpm -q mercurial mercurial-1.4-3.el6.x86_64 # hg view /bin/sh: /usr/libexec/mercurial/hgk: Permission denied --snip-- # rpm -q mercurial mercurial-1.4-4.el6.x86_64 # hg view - opens hg view gui Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1436.html |