Bug 784141 (CVE-2012-0804)

Summary: CVE-2012-0804 cvs: client proxy_connect heap-based buffer overflow
Product: [Other] Security Response Reporter: Vincent Danen <vdanen>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: maurizio, ppisar, rcvalle, security-response-team
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-21 22:42:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 784338, 784339, 784341, 784342, 787683    
Bug Blocks: 784142    
Attachments:
Description Flags
proposed patch to correct the flaw in 1.11 branch with back-ported proxy support
none
Proposed fix for cvs development branch 1.12 none

Description Vincent Danen 2012-01-23 22:59:52 UTC
When correcting a crash in CVS [1] it was found that the CVS client suffers from a flaw that causes a heap overflow.  If certain conditions are met, glib SIGABRTs the process because glibc memory management structures become corrupted.  The flaw is in the proxy_connect() function (src/client.c), where sscanf() copies the first word from read_buf to write_buf without checking if there is enough space in write_buf.

This could allow a malicious HTTP proxy server to cause a denial of service to CVS clients or, possibly, execute arbitrary code on the client system with the privileges of the user running cvs, by sending a malicious HTTP response code to the connecting client.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=773699

Comment 2 Vincent Danen 2012-01-23 23:03:26 UTC
Created attachment 557095 [details]
proposed patch to correct the flaw in 1.11 branch with back-ported proxy support

Comment 12 Tomas Hoger 2012-02-06 13:54:01 UTC
Lifting embargo.

Comment 13 Tomas Hoger 2012-02-06 14:07:00 UTC
Created cvs tracking bugs for this issue

Affects: fedora-all [bug 787683]

Comment 14 Petr Pisar 2012-02-07 15:31:50 UTC
Created attachment 559993 [details]
Proposed fix for cvs development branch 1.12

Comment 15 Fedora Update System 2012-02-15 11:29:50 UTC
cvs-1.11.23-17.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2012-02-15 11:36:46 UTC
cvs-1.11.23-22.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 errata-xmlrpc 2012-02-21 21:17:48 UTC
This issue has been addressed in following products:

  Red Hat Enterprise Linux 6
  Red Hat Enterprise Linux 5

Via RHSA-2012:0321 https://rhn.redhat.com/errata/RHSA-2012-0321.html