Bug 784213

Summary: [ovirt] [engine] import vm with thin-provision disk fails as engine takes into calculation disk size and not actual disk size
Product: [Retired] oVirt Reporter: Dafna Ron <dron>
Component: ovirt-engine-coreAssignee: lpeer <lpeer>
Status: CLOSED WONTFIX QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: unspecifiedCC: acathrow, amureini, ecohen, hateya, iheim, mgoldboi, ykaul
Target Milestone: ---   
Target Release: 3.3.4   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-10 19:10:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
log
none
new log none

Description Dafna Ron 2012-01-24 09:52:59 UTC
Created attachment 557174 [details]
log

Description of problem:

I tried importing a vm created in iscsi with a thin provision disk of 15G to a 15G iscsi domain. the actual size on the vm disk is 2G so there should not be a problem to import the vm. however, I am getting an error that there is not enough space on domain. 

Version-Release number of selected component (if applicable):

ovirt-engine-backend-3.0.0_0001-1.2.fc16.x86_64
ovirt-engine-webadmin-portal-3.0.0_0001-1.2.fc16.x86_64

How reproducible:

100%

Steps to Reproduce:
1. create and export a vm with larger disk size then you have in your domain (actual size should be 1-2G)
2. delete the vm from your setup and try to import it back
3.
  
Actual results:

you get an error that there is not enough disk space on your target domain

Expected results:

there should be no problem importing the vm

Additional info: I do not see any errors in the ovirt engine log so this seems to be coming from webadmin. adding engine log just in case.

Comment 1 Moran Goldboim 2012-01-29 22:07:59 UTC
Dafna, you log seems to be truncated and not include all operations you have described, can you please reproduce with full logs

Comment 2 Dafna Ron 2012-01-30 09:05:08 UTC
as I wrote in the bug, I did not see anything in the backend logs so I opened it on GUI. but I am attaching the reproduction logs (although they seem exactly the same).

Comment 3 Dafna Ron 2012-01-30 09:05:45 UTC
Created attachment 558292 [details]
new log

Comment 4 Haim 2012-01-30 12:35:43 UTC
(In reply to comment #1)
> Dafna, you log seems to be truncated and not include all operations you have
> described, can you please reproduce with full logs

this is a backend issue (there is a CAN_DO_ACTION to substantiate it). 
looking into the flow; 

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java

we check the following: 

retVal = StorageDomainSpaceChecker.hasSpaceForRequest(getStorageDomain(), (int) getVm().getDiskSize());

where .getDiskSize() takes the allocated disk size and not actual ...

Comment 5 Itamar Heim 2012-12-10 19:10:15 UTC
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.