Bug 784305

Summary: Doesn't have %check section although upstream provides unit tests.
Product: [Fedora] Fedora Reporter: Matěj Cepl <mcepl>
Component: python-rdflibAssignee: Dave Malcolm <dmalcolm>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dmalcolm, mcepl, pingou
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-24 21:36:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Matěj Cepl 2012-01-24 14:18:32 UTC 
Description of problem:
just run

python setup.py test

in %check section

Version-Release number of selected component (if applicable):
python-rdflib-3.2.0-3

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Pierre-YvesChibon 2012-01-24 14:41:20 UTC 
Because there seem to be a call to a remote url which is not allowed within the koji infrastructure.

See : http://koji.fedoraproject.org/koji/taskinfo?taskID=3729302

Not sure how upstream would be willing to change this.
Comment 2 Dave Malcolm 2012-01-24 15:45:28 UTC 
FWIW, recent versions of Fedora's python package (2.7.2-10.fc17 onwards iirc) provides some non-standard extensions to unittest, so that you can add this decorator to unit tests in a downstream-only patch:

@unittest._skipInRpmBuild(msg)
def test_something():
   ...etc...

@unittest._expectedFailureInRpmBuild(msg)
def test_something_else():
   ...etc...

You have to explicitly define WITHIN_PYTHON_RPM_BUILD within the environment for them to work.

See 
http://pkgs.fedoraproject.org/gitweb/?p=python.git;a=commitdiff;h=866e9292651403b113045cfd33d238c57cd3201e
for the patch that added this to "python", and applied it in a fine-grained way to the test suite there.

Having said all that, these decorators don't exist in older Fedora python packages, or in RHEL's python packages.
Comment 3 Pierre-YvesChibon 2012-01-24 21:36:23 UTC 
http://koji.fedoraproject.org/koji/buildinfo?buildID=295336

Fix in git and builds fine.