| Summary: | cleanup: unused config values for notification service in engine core | ||
|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Itamar Heim <iheim> |
| Component: | ovirt-engine-core | Assignee: | Greg Padgett <gpadgett> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | acathrow, amureini, dfediuck, gpadgett, iheim, ykaul |
| Target Milestone: | --- | Keywords: | EasyFix |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | infra | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-23 09:21:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Just a general comment, next time when moving to POST, please add a comment with the proposed patch. This will make it easier for reviewers to track the relevant patch(-set). Thanks Doron, still getting the hang of the workflow and appreciate the feedback. Is a link to the gerrit change appropriate? e.g. for this one: http://gerrit.ovirt.org/#/c/4876 That's perfect. Once merged, please add a comment with a link to the merged fix in gitweb. Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug. |
the notification service configuration is now done via a .conf file, rather than as part of engine config. seems like the following can be removed from ConfigValues class (and if they exist in the db for some reason) ENMailHost(183), ENMailPort(184), ENMailUser(185), ENMailPassword(186), ENMailDomain(187), ENMailIsBodyHtml(188), ENMailEnableSsl(189), ENMailUseDefaultCredentials(190),