Bug 784516

Summary: Remove Snapshot Failed due to ill volume preparation
Product: [Retired] oVirt Reporter: Avi Tal <atal>
Component: vdsmAssignee: Eduardo Warszawski <ewarszaw>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: urgent Docs Contact:
Priority: urgent    
Version: unspecifiedCC: abaron, acathrow, bazulay, danken, hateya, iheim, oramraz, srevivo, ykaul
Target Milestone: ---Keywords: Regression, TestBlocker
Target Release: 3.1   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: v4.9.4-5-gbc6b961 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-09 08:04:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
vdsm log none

Description Avi Tal 2012-01-25 09:02:41 UTC
Created attachment 557400 [details]
vdsm log

Description of problem:
vdsm under nfs4 creates data domain with "nobody" as owner instead of vdsm:kvm there for vdsm is unable to remove/marge snapshots on NFS Data Domain.


Steps to Reproduce:
1. Fedora 16 host with latest vdsm
2. create snapshots 
3. try to remove snapshot
4. check the SD directory permissions under /rhev/data-center/<pool>/

In my case:
ll /rhev/data-center/712bee06-1acb-4079-8b1a-06832b2d7e9b/2d369cd6-88ae-412f-b551-5c0b873f64f2/
total 8
drwxr-xr-x 2 nobody nobody 7 Jan 25 10:18 dom_md
drwxr-xr-x 3 nobody nobody 3 Jan 25 10:18 images
drwxr-xr-x 4 nobody nobody 4 Jan 25 10:16 master

vdsm error:
a352b82c-7cd9-4c6e-a6ba-577c0518a872::ERROR::2012-01-25 10:19:23,747::image::1137::Storage.Image::(merge) Unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/image.py", line 1125, in merge
    chainToRemove = self._baseRawVolumeMerge(sdDom, srcVolParams, volParams, chain)
  File "/usr/share/vdsm/storage/image.py", line 1024, in _baseRawVolumeMerge
    srcVol.prepare(rw=True, chainrw=True, setrw=True)
  File "/usr/share/vdsm/storage/volume.py", line 550, in prepare
    self.llPrepare(rw=rw, setrw=False)
  File "/usr/share/vdsm/storage/fileVolume.py", line 297, in llPrepare
    raise se.VolumeAccessError(volPath)
VolumeAccessError: Error accessing a volume: ('/rhev/data-center/712bee06-1acb-4079-8b1a-06832b2d7e9b/2d369cd6-88ae-412f-b551-5c0b873f64f2/images/e5447dd6-b4df-400f-91cf-3aedd89c8261/dc94313d-6136-41a1-bf72-b91b71
56cb86',)

Comment 1 Avi Tal 2012-01-25 09:44:44 UTC
adding nfs_mount_options = soft,nosharecache,vers=3 to vdsm.conf
doesn't solve the problem. 
it does replace nobody:nobody with vdsm:kvm but still remove snapshot failed 
VolumeAccessError: Error accessing a volume

Comment 2 Dan Kenigsberg 2012-01-25 10:34:14 UTC
As comment 1 corrected, this has little to do with NFSv4. It is a regression introduced by

commit 3f799248691a7d7c571f33a03fa6a31cd0940bf9
Author: Eduardo Warszawski <ewarszaw>
Date:   Wed Dec 28 19:40:42 2011 +0200

    BZ#773666 - Fix HSM flows should not change rw permissions.

As already suspected in https://bugzilla.redhat.com/show_bug.cgi?id=782101#c7

Comment 3 Dan Kenigsberg 2012-02-05 08:45:28 UTC
http://gerrit.ovirt.org/#change,1266

Comment 4 Itamar Heim 2012-08-09 08:04:31 UTC
closing ON_QA bugs as oVirt 3.1 was released:
http://www.ovirt.org/get-ovirt/