Bug 784520

Summary: firehol should use iproute instead of net-tools
Product: [Fedora] Fedora Reporter: Jiri Popelka <jpopelka>
Component: fireholAssignee: Christopher Meng <i>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: susi.lehtola
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: firehol-2.0.1-1.el7 firehol-2.0.1-1.fc23 firehol-2.0.1-1.fc22 firehol-2.0.1-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-28 04:37:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 687920    
Attachments:
Description Flags
patch
none
simpler patch
none
also replace netstat with ss none

Description Jiri Popelka 2012-01-25 09:14:19 UTC
Created attachment 557407 [details]
patch

FireHOL has requirement on net-tools however the only reason I see is
use of ifconfig in examples/home-adsl.conf

I see this comment in examples/home-adsl.conf:
# THIS IS AN OLD EXAMPLE SCRIPT, LEFT HERE FOR HISTORICAL REASONS 
# PLEASE USE THE lan-gateway.conf EXAMPLE.

So I think the
Requires:	net-tools >= 1.57
line in firehol.spec could be safely removed.

If you want to replace the ifconfig use with it's 'ip addr' equivalent, see attached patch.

Comment 1 Susi Lehtola 2012-01-25 09:38:20 UTC
I've contacted upstream about this.

Comment 2 Jiri Popelka 2012-01-25 15:35:38 UTC
Created attachment 557467 [details]
simpler patch

Thanks! The patch can be actually more simple.

Comment 3 Jiri Popelka 2012-05-04 17:34:12 UTC
Created attachment 582170 [details]
also replace netstat with ss

I had forgotten about netstat.
I posted this patch upstream at
https://sourceforge.net/tracker/?func=detail&aid=3523571&group_id=58425&atid=487692

Comment 4 Fedora End Of Life 2013-04-03 17:43:38 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 5 Fedora Admin XMLRPC Client 2014-07-22 17:41:27 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 6 Fedora Admin XMLRPC Client 2014-07-22 23:53:28 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 7 Christopher Meng 2015-02-28 04:37:29 UTC
Fixed in 2.0.0-pre4 upstream.

2.0.1 built.