Bug 784592

The path to the .spec file is http://mef.fedorapeople.org/packages/jabref/jpf.spec, I suppose :)

Oops, yes -- cut-and-paste error there. :)

Updated package:
- Remove clean section, install unversioned javadocs

http://mef.fedorapeople.org/packages/jabref/jpf-1.5.1-2.fc16.src.rpm

Some comments for the moment:
- you can get rid of dos2unix as BR, since sed can do the same without bringing an extra BR.
  You can have a look at this page:
      http://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings
- jakarta-commons-logging was renamed apache-commons-logging for a moment. Please use the new name for this dependency.
- %defattr is no longer needed:
      http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
The patches look good for me by the way.

Minor changes:

- Remove defattr from files section
- Add license to javadoc subpackage
- Change jakarta-commons-logging to apache-commons-logging
- Remove dos2unix BuildRequirement; use sed instead

http://mef.fedorapeople.org/packages/jabref/jpf-1.5.1-3.fc16.src.rpm

I'll do this one.

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Rpmlint output:
jpf-javadoc.noarch: E: incorrect-fsf-address /usr/share/doc/jpf-javadoc-1.5.1/license.txt
Not a problem as per http://osdir.com/ml/fedora-legal-list/2011-08/msg00004.html but a few things you can do a listed there.
jpf.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
jpf.noarch: E: incorrect-fsf-address /usr/share/doc/jpf-1.5.1/license.txt
2 packages and 0 specfiles checked; 2 errors, 1 warnings.                                                                       jpf.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment                                                                        
[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type:LGPLv2
[x]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided in the spec URL.
MD5SUM this package    :5cad62837c7c1c499e611df206893f07
MD5SUM upstream package:5cad62837c7c1c499e611df206893f07
[x]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates or must require other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing)
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[!]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms
[x]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment
[x]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.


=== Issues ===
1. Please use apache-commons-logging (this was not fixed).
2. Please use sed not dos2unit
3. Please remove rm -rf $RPM_BUILD_ROOT from %install section

4. Add Requires: jpackage-utils to the javadoc subpackage as it installs in folder owned by it.

Updated:
- Change jakarta-commons-logging to apache-commons-logging
- Remove dos2unix BuildRequirement; use sed instead
- Get rid of rogue "rm -rf" from install section
- Add jpackage-utils to javadoc requirement

http://mef.fedorapeople.org/packages/jabref/jpf-1.5.1-4.fc16.src.rpm
http://mef.fedorapeople.org/packages/jabref/jpf.spec

Looks good.

APPROVED.

New Package SCM Request
=======================
Package Name:      jpf
Short Description: Java Plug-In Framework
Owners:            mef
Branches:          f17

Git done (by process-git-requests).

jpf-1.5.1-4.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/jpf-1.5.1-4.fc17

jpf-1.5.1-4.fc17 has been pushed to the Fedora 17 testing repository.

jpf-1.5.1-4.fc17 has been pushed to the Fedora 17 stable repository.