Bug 784803

Summary: rkhunter doesn't need to require net-tools
Product: [Fedora] Fedora Reporter: Jiri Popelka <jpopelka>
Component: rkhunterAssignee: Kevin Fenzi <kevin>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: kevin
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-28 03:48:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 687920    

Description Jiri Popelka 2012-01-26 09:43:50 UTC 
Rootkit Hunter has requirement on net-tools however when I check [1] what tools does it use I find only the following code in rkhunter-1.3.8/files/rkhunter:

if [ -n "${IFCONFIG_CMD}" ]; then
  case "${OPERATING_SYSTEM}" in
    *BSD|DragonFly)
    ;;
    SunOS|IRIX*|AIX)
    ;;
    *)
      PROMISCSCAN1=`${IFCONFIG_CMD} 2>&1 | ...`
    ;;
  esac
  if [ $LINUXOS -eq 1 ]; then
	if [ -n "${IP_CMD}" ]; then
	PROMISCSCAN2=`${IP_CMD} link | ...`
	fi
  fi

That means that on Linux it's able to use both ifconfig (${IFCONFIG_CMD}) and ip (${IP_CMD}) to check the promiscuous mode of network interfaces.

As you maybe know net-tools (ifconfig) has been deprecated for some time.
We (as well as other distributions) try to eviscerate net-tools' use from as many packages as possible and replace it with iproute.

So what about removing the 'Requires: net-tools' from rkhunter.spec ?
Given that rkhunter is already able to use ip command there should be no problem.


[1] grep -i -R -E 'arp|etherwake|ifconfig|ipmaddr|iptunnel|mii-diag|mii-tool|nameif|plipconfig|route|slattach' *
Comment 1 Kevin Fenzi 2012-01-28 03:48:02 UTC 
Seems reasonable. 

Commited and built in rawhide. Thanks for the report!