Bug 784944
| Summary: | Review Request: ktp-accounts-kcm - KDE Configuration Module for Telepathy Instant Messaging Accounts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | nucleo <alekcejk> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, notting, package-review |
| Target Milestone: | --- | Flags: | alekcejk:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-10 22:09:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 784945 | ||
| Bug Blocks: | 656997, 784939 | ||
|
Description
Rex Dieter
2012-01-26 18:37:18 UTC
name: ok
summary: ok
license: ok
handling locale files: ok
Obsoletes/Provides: ok
BuildRequires: telepathy-qt4-deve not needed because ktp-common-internals-devel requires it.
"rm -f %{buildroot}%{_kde4_libdir}/libkcmtelepathyaccounts.so" is actually not removes anything. Maybe it should be "rm -f %{buildroot}%{_kde4_libdir}/
libktpaccountskcminternal.so" and remove %{_kde4_libdir}/libktpaccountskcminternal.so?
ldd shows that libs installed in kde4 requires only versioned libktpaccountskcminternal.so.4.
This will fix rpmlint warning:
ktp-accounts-kcm.i686: W: devel-file-in-non-devel-package /usr/lib/libktpaccountskcminternal.so
More detailed description can be added from README.
There are many protocol dependencies:
Requires: telepathy-butterfly
Requires: telepathy-gabble
Requires: telepathy-haze
Requires: telepathy-idle
Requires: telepathy-rakia
Requires: telepathy-salut
Requires: telepathy-sunshine
So maybe it makes sense to place every protocol in subpackage with corresponding dependency?
Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-accounts-kcm.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-accounts-kcm-0.3.0-1.fc16.src.rpm %changelog * Tue Feb 07 2012 Rex Dieter <rdieter> 0.3.0-2 - improve %%description - drop BR: telepathy-qt4-devel - omit libktpaccountskcminternal.so Re: So maybe it makes sense to place every protocol in subpackage with corresponding dependency? perhaps, but * currently its simplified to "just work", and follows how gnome/empathy does things * If we decide to do otherwise, that's a design decision I'd rather make as a team later, and (imo) shouldn't be considered a review blocker here and now. APPROVED New Package SCM Request ======================= Package Name: ktp-common-internals Short Description: Common internals for KDE Telepathy Owners: jreznik rdieter Branches: f16 copy-n-paste fail, let's try again, New Package SCM Request ======================= Package Name: ktp-accounts-kcm Short Description: KDE Configuration Module for Telepathy Instant Messaging Accounts Owners: jreznik rdieter Branches: f16 Git done (by process-git-requests). Please take ownership of review BZs. Thanks! Added f17. You can't unassign yourself from an already approved review. imported |