Bug 784956
| Summary: | Review Request: ktp-send-file - A File manager plugin to launch file transfer jobs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | nucleo <alekcejk> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alekcejk, kevin, notting, package-review |
| Target Milestone: | --- | Flags: | alekcejk:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-10 22:09:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 784945 | ||
| Bug Blocks: | 656997, 784939 | ||
|
Description
Rex Dieter
2012-01-26 19:01:10 UTC
Summary: A File manager plugin to launch a file transfer job with a specified contact.
Is this summary not too long?
# service menu only, desktop validation not required
# in a perfect world, this would get moved to datadir/kde4/services/
%{_kde4_datadir}/applications/kde4/ktp-send-file.desktop
So can be moved to services dir? This can fix rpmlint errors:
ktp-send-file.i686: E: invalid-desktopfile /usr/share/applications/kde4/ktp-send-file.desktop (will be fatal in the future): value "all/allfiles;" for key "MimeType" in group "Desktop Entry" contains value "all/allfiles" which is an invalid MIME type: "all" is an unregistered media type
ktp-send-file.i686: E: invalid-desktopfile /usr/share/applications/kde4/ktp-send-file.desktop required key "Name" in group "Desktop Entry" is not present
ktp-send-file.i686: E: invalid-desktopfile /usr/share/applications/kde4/ktp-send-file.desktop key "MimeType" is present in group "Desktop Entry", but the type is "Service" while this key is only valid for type "Application"
%find_lang %{name} --all-name --with-kde
%find_lang works here without --all-name
BuildRequires: desktop-file-utils is not needed if it not used. BuildRequires: telepathy-qt4-devel also not needed because ktp-common-internals-devel requires it. Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-send-file.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-send-file-0.3.0-1.fc16.src.rpm %changelog * Tue Feb 07 2012 Rex Dieter <rdieter> 0.3.0-2 - shorten Summary - drop BR: desktop-file-utils telepathy-qt4-devel Re: %find_lang %{name} --all-name --with-kde %find_lang works here without --all-name true, but I'd rather be safe and have it automatically include HTML handbooks if they ever get included upstream. Re: So can be moved to services dir? I think I tried that, and it didn't work. Besides, rpmlint should probably be fixed to only operate on .desktop files containing Type=Application (which is not the case here) name: ok summary: ok license: ok BuildRequires: ok Obsoletes/Provides: ok handling locale files: ok APPROVED > summary: ok No, it isn't "ok" for various reasons: > Name: ktp-send-file > Summary: A File manager plugin to launch file transfer jobs While the big 'F' in "File manager" may be just a typo, one wonders _which file manager_ is this for? Summaries without leading articles also are more readable, btw. > %description > %{summary}. The same that I've added to bug 784950 applies here. I'll look into improving the description prior to doing any builds, thanks. New Package SCM Request ======================= Package Name: ktp-send-file Short Description: A File manager plugin to launch file transfer jobs Owners: jreznik rdieter Branches: f16 Git done (by process-git-requests). imported |