Bug 785057

Summary:	Review Request: perl-Net-Server-Coro - Co-operative multithreaded server using Coro
Product:	[Fedora] Fedora	Reporter:	Mathieu Bridon <bochecha>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, panemade, ppisar
Target Milestone:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-03 08:06:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mathieu Bridon 2012-01-27 04:56:51 UTC

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Net-Server-Coro.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Net-Server-Coro-1.2-1.fc16.src.rpm

Description:
Net::Server::Coro implements multithreaded server for the Net::Server
architecture, using Coro and Coro::Socket to make all reads and writes non-
blocking. Additionally, it supports non-blocking SSL negotiation.


$ rpmlint perl-Net-Server-Coro*
perl-Net-Server-Coro.noarch: W: spelling-error Summary(en_US) multithreaded -> multicolored
perl-Net-Server-Coro.noarch: W: spelling-error %description -l en_US multithreaded -> multicolored
perl-Net-Server-Coro.src: W: spelling-error Summary(en_US) multithreaded -> multicolored
perl-Net-Server-Coro.src: W: spelling-error %description -l en_US multithreaded -> multicolored
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Comment 1 Parag AN(पराग) 2012-02-02 06:20:37 UTC

Review:-

+ koji build (f17) -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3754354

+ rpmlint on rpms gave
perl-Net-Server-Coro.src: W: spelling-error Summary(en_US) multithreaded -> multicolored
perl-Net-Server-Coro.src: W: spelling-error %description -l en_US multithreaded -> multicolored
perl-Net-Server-Coro.noarch: W: spelling-error Summary(en_US) multithreaded -> multicolored
perl-Net-Server-Coro.noarch: W: spelling-error %description -l en_US multithreaded -> multicolored
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ License is valid

+ source verified with upstream as (sha1sum)
0d33fa51f9ad50dd22a03d1c5b46407f750836e6  Net-Server-Coro-1.2.tar.gz
0d33fa51f9ad50dd22a03d1c5b46407f750836e6  ../SOURCES/Net-Server-Coro-1.2.tar.gz


+ Package perl-Net-Server-Coro-1.2-1.fc17.noarch =>
Provides: perl(Net::Server::Coro) = 1.2 perl(Net::Server::Proto::Coro) perl(Net::Server::Proto::Coro::FH)

Requires: perl(Coro) perl(Coro::Handle::FH) perl(Coro::Socket) perl(Coro::Specific) perl(Coro::Util) perl(EV) perl(Net::Server) perl(Net::Server::Proto::Coro) perl(Net::Server::Proto::TCP) perl(Socket) perl(base) perl(constant) perl(strict) perl(vars) perl(warnings)

+ Follows packaging guidelines.

APPROVED.

Comment 2 Mathieu Bridon 2012-02-02 06:27:47 UTC

Thanks Parag!

New Package CVS Request
=======================
Package Name: perl-Net-Server-Coro
Short Description: Co-operative multithreaded server using Coro
Owners: bochecha
Branches: f16 el6
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2012-02-02 07:48:29 UTC

Git done (by process-git-requests).

Comment 4 Mathieu Bridon 2012-02-03 08:06:10 UTC

Thank you Jon.

Package built in all branches, closing the ticket.

Comment 5 Petr Pisar 2012-02-03 08:30:08 UTC

Excuse me, the Makefile.PL uses inc::Module::Install, which is provided by separate package perl-Module-Install (in F17). I think this package should build-require `perl(inc::Module::Install)'.

Also it would be good to delete `inc' subdirectory before building to remove bundled Module::Install.

Comment 6 Mathieu Bridon 2012-02-06 04:13:42 UTC

Thanks Petr, good catch!

I've fixed this, it's building and I'll obsolete the packages I had already submitted to testing.

(Note: I see this bug is fixed as NOTABUG rather than NEXTRELEASE. I guess I chose the wrong one when I closed it, so I'm changing it now, in case that matters to somebody)