Bug 785444 (Horde_Alarm)

I believe this one is ready to review now.

I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package.

As Horde_Test is approved, I think we must now run the test suite during build, something like:

# For tests
BuildRequires:  php-pear(pear.horde.org/Horde_Test)
BuildRequires:  php-pear(pear.horde.org/Horde_Date)
BuildRequires:  php-pear(pear.horde.org/Horde_Exception)
BuildRequires:  php-pear(pear.horde.org/Horde_Translation)

%check
cd $RPM_BUILD_ROOT%{pear_testdir}/Horde_Alarm/Horde/Alarm
phpunit \
   -d date.timezone=UTC \
   -d include_path=.:$RPM_BUILD_ROOT%{pear_phpdir}:%{pear_phpdir}: \
   AllTests 


Some tests will be skipped, need more BR for this (but, p.e. Horde_Notification is not yet approved, search for markTestSkipped in *.php) and probably a DB for some test (see conf.php.dist).

Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Alarm.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Alarm-2.0.2-1.fc17.src.rpm

(In reply to comment #4)

After quick review:
* Missing %{pear_metadir}
* Please group your build requires together

Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Alarm.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Alarm-2.0.3-2.fc17.src.rpm

Created attachment 693768 [details]
phpci.log

Created attachment 693769 [details]
php-horde-Horde-Alarm-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785444

[!]: Package installs properly.
     Note: Installation errors (see attachment)

	Wait for dependencies before import in repository
	(not a blocker for the review)

[!]: License field in the package spec file matches the actual license.
	Headers and COPYING explicit use LGPL v2.1 (without "any later" option)
	So, LGPLv2 (not LGPLv2+)

Just need to fix the License, else everything is ok.

Can you please replace my "private" email by my fp.o one ?

Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Alarm.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Alarm-2.0.3-3.fc17.src.rpm

< License:        LGPLv2+
> License:        LGPLv2

[x]: License field in the package spec file matches the actual license.

No blocker

=== APPROVED ===

New Package SCM Request
=======================
Package Name: php-horde-Horde-Alarm
Short Description: Horde Alarm Libraries 
Owners: nb remi
Branches: el6 f18
InitialCC:

Git done (by process-git-requests).

php-horde-Horde-Alarm-2.0.3-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-horde-Horde-Alarm-2.0.3-3.fc18

php-horde-Horde-Alarm-2.0.3-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-Horde-Alarm-2.0.3-3.el6

Package php-horde-Horde-Alarm-2.0.3-3.fc18, php-horde-Horde-Image-2.0.3-3.fc18, php-horde-Horde-Lock-2.0.1-3.fc18, php-horde-Horde-Text-Flowed-2.0.1-3.fc18, php-horde-Horde-Argv-2.0.4-4.fc18, php-horde-Horde-Serialize-2.0.1-3.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing php-horde-Horde-Alarm-2.0.3-3.fc18 php-horde-Horde-Image-2.0.3-3.fc18 php-horde-Horde-Lock-2.0.1-3.fc18 php-horde-Horde-Text-Flowed-2.0.1-3.fc18 php-horde-Horde-Argv-2.0.4-4.fc18 php-horde-Horde-Serialize-2.0.1-3.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-2619/php-horde-Horde-Argv-2.0.4-4.fc18,php-horde-Horde-Serialize-2.0.1-3.fc18,php-horde-Horde-Text-Flowed-2.0.1-3.fc18,php-horde-Horde-Lock-2.0.1-3.fc18,php-horde-Horde-Image-2.0.3-3.fc18,php-horde-Horde-Alarm-2.0.3-3.fc18
then log in and leave karma (feedback).

php-horde-Horde-Alarm-2.0.3-3.fc18, php-horde-Horde-Image-2.0.3-3.fc18, php-horde-Horde-Lock-2.0.1-3.fc18, php-horde-Horde-Argv-2.0.4-4.fc18, php-horde-Horde-Serialize-2.0.1-3.fc18, php-horde-Horde-Text-Flowed-2.0.1-4.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

php-horde-Horde-Image-2.0.3-3.el6, php-horde-Horde-Alarm-2.0.3-3.el6, php-horde-Horde-Lock-2.0.1-3.el6, php-horde-Horde-Argv-2.0.4-4.el6, php-horde-Horde-Serialize-2.0.1-3.el6, php-horde-Horde-Text-Flowed-2.0.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.