Bug 785469 (Horde_LoginTasks)
| Summary: | Review Request: php-horde-Horde-LoginTasks - Horde Login Tasks System | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nick Bebout <nb> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, notting, package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-03-27 20:28:55 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 785424, 785432 | ||||||||
| Bug Blocks: | 908329 | ||||||||
| Attachments: |
|
||||||||
|
Description
Nick Bebout
2012-01-29 02:45:33 UTC
I will review this package After a quick review: [MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml [MUST] Fix file-not-in-%lang rpmlint warnings [SHOULD] %check is present and all tests pass [SHOULD] Localized php.ini not necessary (see https://bugzilla.redhat.com/show_bug.cgi?id=785471#c5) Please update to 2.0.1 Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks-2.0.2-2.fc17.src.rpm Created attachment 693926 [details]
phpci.log
Created attachment 693927 [details]
php-horde-Horde-LoginTasks-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785469
[!]: License field in the package spec file matches the actual license. # Horde files are LGPLv2 (not LGPLv2+) # Horde/Image/Exif/Parser/Canon.php is GPLv2+ => GPLv2+ and LGPLv2 Just need to fix the License, else everything is ok. Can you please replace my "private" email by my fp.o one ? [!]: License field in the package spec file matches the actual license. LGPLv2 (not LGPLv2+) Just need to fix the License, else everything is ok. Can you please replace my "private" email by my fp.o one ? ignore comment #7 (copy/paste error) Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks-2.0.2-3.fc17.src.rpm It seems you miss the License field... Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks-2.0.2-4.fc17.src.rpm License fixed. === APPROVED === New Package SCM Request ======================= Package Name: php-horde-Horde-LoginTasks Short Description: A set of methods for dealing with tasks run upon login to Horde applications Owners: nb remi Branches: el6 f18 f19 InitialCC: Git done (by process-git-requests). php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.el6,php-horde-Horde-LoginTasks-2.0.2-4.el6,php-horde-Horde-Stream-Filter-2.0.1-4.el6,php-horde-Horde-Token-2.0.3-3.el6 php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.fc18,php-horde-Horde-Group-2.0.2-1.fc18,php-horde-Horde-LoginTasks-2.0.2-4.fc18,php-horde-Horde-Stream-Filter-2.0.1-4.fc18,php-horde-Horde-Token-2.0.3-3.fc18 php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 testing repository. php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been pushed to the Fedora 18 stable repository. php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository. |