Bug 785471 (horde-stream-wrapper)

Summary: Review Request: php-horde-Horde-Stream-Wrapper - Horde Stream wrappers
Product: [Fedora] Fedora Reporter: Nick Bebout <nb>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, shawn
Target Milestone: ---Flags: fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-07-18 22:05:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 785424    
Bug Blocks: 785455    
Attachments:
Description Flags
php-horde-Horde-Stream-Wrapper-review.txt none

Description Nick Bebout 2012-01-29 02:53:16 UTC 
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0.0-1.fc16.src.rpm
Description: This package provides various stream wrappers.
Comment 1 Nick Bebout 2012-06-21 21:03:26 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0.1-1.fc16.src.rpm
Comment 2 Remi Collet 2012-06-30 07:34:13 UTC 
Created attachment 595422 [details]
php-horde-Horde-Stream-Wrapper-review.txt

Generated by fedora-review 0.1.3
Comment 3 Remi Collet 2012-06-30 07:37:50 UTC 
SHOULD:
Use %{pear_name} where possible
Consider adding %{pear_channel}

MUST:
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.

[!]: MUST Requires correct, justified where necessary.
BuildRequires and Requires same version of pear, according to package.xml
BuildRequires:  php-pear >= 1:1.7.0
Requires:  php-pear >= 1:1.7.0

Also add php-common >= 5.2.0 (waiting for a better provides in php)

[!]: MUST Package must own all directories that it creates.
Missing
%{pear_phpdir}/Horde
%{pear_phpdir}/Horde/Stream
%{pear_docdir}/Horde_Stream_Wrapper
Comment 4 Nick Bebout 2012-07-10 22:36:43 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0.1-2.fc16.src.rpm
Comment 5 Remi Collet 2012-07-11 05:08:23 UTC 
[!]: MUST Package must own all directories that it creates.
Missing
%{pear_phpdir}/Horde

And you should, of course remove (included in previous)
%{pear_phpdir}/Horde/Stream
%{pear_phpdir}/Horde/Stream/Wrapper

Please use macro everywhere, see %postun and %files

It's probably enough to only 
%doc %{pear_docdir}/%{pear_name}

Note : "localized" php.ini is use less in fedora (date.timezone defined in pear wrapper), I haven't check in EL.
Comment 6 Nick Bebout 2012-07-12 23:54:50 UTC 
Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0.1-3.fc16.src.rpm
Comment 7 Remi Collet 2012-07-17 14:03:02 UTC 
Blockers fixed.

== APPROVED ==
Comment 8 Nick Bebout 2012-07-17 22:42:09 UTC 
New Package SCM Request
=======================
Package Name: php-horde-Horde-Stream-Wrapper
Short Description: This package provides various stream wrappers for Horde
Owners: nb
Branches: el6 f16 f17
InitialCC:
Comment 9 Gwyn Ciesla 2012-07-18 03:16:31 UTC 
Git done (by process-git-requests).