Bug 785493 (Horde_Cli)
| Summary: | Review Request: php-horde-Horde-Cli - Horde Command Line Interface API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nick Bebout <nb> | ||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora, kc8hfi, notting, package-review, shawn | ||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-12-12 22:49:19 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 785424, 785432, 785455 | ||||||
| Bug Blocks: | 785606 | ||||||
| Attachments: |
|
||||||
|
Description
Nick Bebout
2012-01-29 04:25:35 UTC
I am not an official package reviewer, but here are some comments I have for this package: *** Per package.xml requirements, please add: Requires: php-common >= 5.2.0 *** phpci results: For completeness (and to prevent any future packaging issues due to PHP package changes), you may wish to require the virtual packages "php-pcre" and "php-session". I believe I have fixed these issues: Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cli.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cli-1.0.4-2.fc16.src.rpm I'm not an official package reviewer. I did see something about the BuildRequires. It says php-channel(pear.horde.org). I searched the repos for that, and found the php-channel-horde. I installed that and the package built successfully. I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package. Created attachment 601938 [details]
php-horde-Horde-Cli-review.txt
Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
Could: localized php.ini is no more useful (timezone defined in pear wrapper) Could: requires php(language) >= 5.2.0 per new PHP Guildelines, but this is fedora specific (for now), so php-common seems acceptable as you target both fedora/epel No blocker *** APPROVED *** New Package SCM Request ======================= Package Name: php-horde-Horde-Cli Short Description: API for basic command-line functionality/checks Owners: nb Branches: el6 f16 f17 InitialCC: Git done (by process-git-requests). |