Bug 785496
| Summary: | Review Request: php-horde-Horde-History - API for tracking the history of an object | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nick Bebout <nb> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, notting, package-review, shawn |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-02-10 17:04:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nick Bebout
2012-01-29 04:41:45 UTC
I am not an official package reviewer, but here are some comments I have for this package: *** It would help readability to group your Build* and Requires* statements together instead of mixing them with each other and your Provides and Conflicts statements *** Your BuildRequires should be BuildRequires: php-pear(PEAR) >= 1.7.0 instead of BuildRequires: php-pear >= 1:1.4.9-1.2 (this would match what you have in bug 785606 and satisfy this package's package.xml dependency) *** Your Provides statement should be Provides: php-pear(pear.horde.org/%{pear_name}) = %{version} instead of Provides: php-pear(%{pear_name}) = %{version} *** phpci results: For completeness (and to prevent any future packaging issues due to PHP package changes), you may wish to require the virtual provide "php-date". *** Do you plan on building for EPEL 5? - If not, please remove "rm -rf $RPM_BUILD_ROOT" from the %install section (see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag). - If you do, there are several staements that need to be added. I believe I have fixed all of these issues: Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-History.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-History-1.0.1-1.fc16.src.rpm (In reply to comment #2) Ready for official review. (In reply to comment #3) > Ready for official review. I take that back. Please add: Requires: php-common >= 5.2.0 I believe I have fixed all of these issues: Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-History.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-History-1.0.1-2.fc16.src.rpm I have updated / submitted this one *** This bug has been marked as a duplicate of bug 909713 *** |