Bug 785517

Summary:	better to have separate thread dump log file for ruby app
Product:	OKD	Reporter:	Shirley Zhou <szhou>
Component:	oc	Assignee:	Bill DeCoste <wdecoste>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	CC:	bmeng, mshao, wdecoste, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-02 23:55:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Shirley Zhou 2012-01-29 09:59:42 UTC

Description of problem:
for ruby thread dump log, it is saved in error_log.log file, QE think it is better make a separate log file for thread dump file.

Version-Release number of selected component (if applicable):
rhc-0.85.5-1.git.0.4eb5d43.el6.noarch
devenv_1564

How reproducible:
100%

Steps to Reproduce:
1.create ruby app
2.generate thread dump file for this ruby app
3.get message as following:
" The thread dump file will be available via 'rhc-tail-files -f ruby/logs/error_log-20120129-000000-EST' "

  
Actual results:
1. use error log file to save thread dump log
2. -a $appname lost in message

Expected results:
1. Better to have separate file to save thread dump log
2. message should contain "-a $appname"
Additional info:

Comment 1 Bill DeCoste 2012-01-29 17:41:43 UTC

Thread dumps go to stdout. Apache already has logging to this stream. This is the file people would want to monitor. I will add #2.

Comment 2 Shirley Zhou 2012-01-30 07:38:13 UTC

Assign this bug back, as ruby app type still miss -a $appname option. 

Jbossas app was ok, while after commit ba7607c5d34a6ad27aa2e8b4b3a4ded30723d166 

'rhc-tail-files -a  -f ruby4/jbossas-7.0/stdout.log -a jboss4'

                ^^

One more -a option show up.

Comment 3 Bill DeCoste 2012-01-30 15:21:53 UTC

updated ruby

Comment 4 Meng Bo 2012-01-31 07:10:01 UTC

checked this issue on devenv_1572 with rhc-0.85.9-1.el6_2.noarch,
the output is list below，
1.for ruby app:
The thread dump file will be available via 'rhc-tail-files -a  -f ruby1/logs/error_log-20120131-000000-EST'
missing $appname in the output.

2.for jbossas app:
The thread dump file will be available via 'rhc-tail-files -a  -f jbs1/jbossas-7.0/stdout.log -a jbs1'
redundant para -a following the command rhc-tail-files.

assign this bug back and please help check it.

Comment 5 Bill DeCoste 2012-01-31 16:31:45 UTC

Fixed - is now 'rhc-tail-files -a appname ...'

Comment 6 Xiaoli Tian 2012-02-01 07:19:00 UTC

(In reply to comment #5)
> Fixed - is now 'rhc-tail-files -a appname ...'

Hi,Bill

There may be some misunderstanding about comment 4, we expect the message to be like this :
The thread dump file will be available via 'rhc-tail-files -a jboss1 -f jboss1/jbossas-7.0/stdout.log '

But current message problem are like following: 

1. Duplicate "-a option" while thread dump jboss app:

The thread dump file will be available via 'rhc-tail-files -a appname -f 
                                                           ^^^^^^^^^^
jboss1/jbossas-7.0/stdout.log -a jboss1'
                              ^^^^^^^^^

2. Not set the exact $appname but a fixed "appname" string while thread dump ruby app:

The thread dump file will be available via 'rhc-tail-files -a appname  -f
                                                              ^^^^^^^
ruby1/logs/error_log-20120131-000000-EST'

Thanks for correcting.

Comment 7 Bill DeCoste 2012-02-01 13:19:58 UTC

Should finally have this right this time!

Comment 8 Xiaoli Tian 2012-02-02 06:17:25 UTC

(In reply to comment #7)
> Should finally have this right this time!

Verified it on devenv-stage_119 with 
rhc-cartridge-jbossas-7.0-0.85.9-1.el6_2.noarch
rhc-cartridge-rack-1.1-0.85.12-1.el6_2.noarch
rhc-0.85.11-1.el6_2.noarch

It's fixed.

Comment 9 Mrunal Patel 2012-02-02 23:55:24 UTC

Closing verified bugs.