Bug 785663

Summary: Review Request: rubygem-journey - Journey is a router
Product: [Fedora] Fedora Reporter: Vít Ondruch <vondruch>
Component: Package ReviewAssignee: Bohuslav "Slavek" Kabrda <bkabrda>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bkabrda, notting, package-review
Target Milestone: ---Flags: bkabrda: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-30 14:14:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Vít Ondruch 2012-01-30 09:00:59 UTC 
Spec URL: http://people.redhat.com/vondruch/rubygem-journey.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-journey-1.0.1-1.fc17.src.rpm
Description: Journey is a router. It routes requests.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3745455
Comment 1 Bohuslav "Slavek" Kabrda 2012-01-30 09:15:53 UTC 
I'll take this for a review.
Comment 2 Bohuslav "Slavek" Kabrda 2012-01-30 09:41:13 UTC 
- README.md should be present in the main package, as it contains licensing information.
- Otherwise the package is OK (although, as FPC [1], I have a general feel of distaste about the bundled javascript libraries - but since they are currently allowed, it is not a blocker).

[1] https://fedorahosted.org/fpc/ticket/113


So after you fix the issue, this package is APPROVED.
Comment 3 Vít Ondruch 2012-01-30 09:55:47 UTC 
(In reply to comment #2)
> - README.md should be present in the main package, as it contains licensing
> information.

Done

> - Otherwise the package is OK (although, as FPC [1], I have a general feel of
> distaste about the bundled javascript libraries - but since they are currently
> allowed, it is not a blocker).
> 
> [1] https://fedorahosted.org/fpc/ticket/113
> 
> 
> So after you fix the issue, this package is APPROVED.


Thank you for your review!

New Package SCM Request
=======================
Package Name: rubygem-journey
Short Description: Journey is a router
Owners: vondruch
Branches: 
InitialCC:
Comment 4 Gwyn Ciesla 2012-01-30 13:31:24 UTC 
Git done (by process-git-requests).