Bug 785671

Summary: ovirt-engine-core: after trying to add a snapshot while a snapshot is created and getting an error vm CreateAllSnapshotsFromVmCommand will fail to aquire lock forever
Product: [Retired] oVirt Reporter: Dafna Ron <dron>
Component: ovirt-engine-coreAssignee: mkublin <mkublin>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: urgent Docs Contact:
Priority: urgent    
Version: unspecifiedCC: acathrow, bazulay, iheim, ofrenkel, oschreib, ykaul
Target Milestone: ---   
Target Release: 3.1   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-09 07:58:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
log none

Description Dafna Ron 2012-01-30 09:55:48 UTC
Created attachment 558295 [details]
log

Description of problem:

after trying to create a snapshot while same operation is already started, will cause a lock issue which will prevent from creating snapshot for the vm even when the vm is no longer in image lock. 

2012-01-30 11:45:25,526 INFO  [org.ovirt.engine.core.bll.CreateAllSnapshotsFromVmCommand] (http--0.0.0.0-8080-3) Failed to Acquire Lock to object EngineLock [exclusiveLocks= key: org.ovirt.engine.core.bll.CreateAllSnapshotsFromVmCommand value: ba681f03-5c6e-483d-9265-504c90042388

seems like this might be a db issue since we are able to delete snapshots and perform other actions. seems like lock might not be cleared in db. 

Version-Release number of selected component (if applicable):

ovirt-engine-backend-3.0.0_0001-1.4.fc16.x86_64

How reproducible:

100%

Steps to Reproduce:
1. create a snapshot and before vm gets into image locked try to create another snapshot
2. after the vm finished creating the first snapshot -> try to create a snapshot again
3.
  
Actual results:

we get an error in web admin and log shows Failed to Acquire Lock to object EngineLock

Expected results:

we should be able to create a snapshot

Additional info:full log

Comment 1 mkublin 2012-01-31 07:34:59 UTC
Please check that the following commit was inside of your branch : 7eb04bb3a869daf97d2f4ec232c463cc4ce44461, it should solve that issue.
The problem is not related to DB

Comment 2 Dafna Ron 2012-01-31 09:04:36 UTC
(In reply to comment #1)
> Please check that the following commit was inside of your branch :
> 7eb04bb3a869daf97d2f4ec232c463cc4ce44461, it should solve that issue.
> The problem is not related to DB

Ofer, can you please tell us if above commit is in ovirt-engine-backend-3.0.0_0001-1.4.fc16.x86_64

Comment 3 Ofer Schreiber 2012-01-31 09:24:08 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Please check that the following commit was inside of your branch :
> > 7eb04bb3a869daf97d2f4ec232c463cc4ce44461, it should solve that issue.
> > The problem is not related to DB
> 
> Ofer, can you please tell us if above commit is in
> ovirt-engine-backend-3.0.0_0001-1.4.fc16.x86_64

Sure it wasn't.
We cherry-pick only blockers since 7af278756a11f94d00ae2066f0e0a4db76442999

If this is a release blocker, we need to add that to the known blockers.

Comment 4 mkublin 2012-01-31 10:15:30 UTC
The commit should solve described issue, the similar problem to Dafna's was also found due internal testing and was fixed with out any opened a new bug, so I think these is a reason that bug was not defined as blocker and was not cherry picked

Comment 7 Itamar Heim 2012-08-09 07:58:27 UTC
closing ON_QA bugs as oVirt 3.1 was released:
http://www.ovirt.org/get-ovirt/