Bug 785711

Summary: Review Request: rubygem-map - String/symbol indifferent ordered hash
Product: [Fedora] Fedora Reporter: Bohuslav "Slavek" Kabrda <bkabrda>
Component: Package ReviewAssignee: Vít Ondruch <vondruch>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, vondruch
Target Milestone: ---Flags: vondruch: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-01 09:02:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Bohuslav "Slavek" Kabrda 2012-01-30 12:41:18 UTC 
Spec URL: http://bkabrda.fedorapeople.org/pkgs/map/rubygem-map.spec
SRPM URL: http://bkabrda.fedorapeople.org/pkgs/map/rubygem-map-5.2.0-1.fc16.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3745841

Description: The awesome ruby container you've always wanted: a string/symbol
indifferent ordered hash that works in all rubies.
Comment 1 Vít Ondruch 2012-01-30 13:51:27 UTC 
I take it for a review.
Comment 2 Vít Ondruch 2012-01-30 13:51:46 UTC 
* Spec file differences
  - The spec file you provides differs from the spec file in SRPM. The SRPM
    version looks better IMO. Please make sure which one you are using.

* License
  - The license file says "same as ruby's". However, the license between
    Ruby 1.8 and Ruby 1.9, differs. Would you mind to clarify the license with
    upstream?

Otherwise I have no other concerns => APPROVED.
Comment 3 Bohuslav "Slavek" Kabrda 2012-01-31 07:34:02 UTC 
(In reply to comment #2)
> * Spec file differences
>   - The spec file you provides differs from the spec file in SRPM. The SRPM
>     version looks better IMO. Please make sure which one you are using.

Sorry about that, fixed :)
 
> * License
>   - The license file says "same as ruby's". However, the license between
>     Ruby 1.8 and Ruby 1.9, differs. Would you mind to clarify the license with
>     upstream?
> 

Solved to BSD or Ruby: https://github.com/ahoward/map/issues/10

> Otherwise I have no other concerns => APPROVED.


New Package SCM Request
=======================
Package Name: rubygem-map
Short Description: String/symbol indifferent ordered hash
Owners: bkabrda
Branches: 
InitialCC:
Comment 4 Gwyn Ciesla 2012-01-31 14:11:50 UTC 
Git done (by process-git-requests).