Bug 785748

Summary:	Attempting to copy an archived rule would not be visible in the respective package
Product:	[JBoss] JBoss Enterprise BRMS Platform 5	Reporter:	Musharraf Hussain <mhussain>
Component:	BRM (Guvnor)	Assignee:	manstis
Status:	VERIFIED ---	QA Contact:	Sona Mala <smala>
Severity:	medium	Docs Contact:
Priority:	high
Version:	5.1.0 GA	CC:	atangrin, jcoleman, lpetrovi, manstis, rwagner, rzhang
Target Milestone:	GA
Target Release:	BRMS 5.3.0.GA
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Attempting to copy an archived rule previously created a copy of the archived rule, however, the copy was also archived and did not show up in the package it was copied to. This has been resolved by removing the ability to copy archived rules.	Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Musharraf Hussain 2012-01-30 14:25:55 UTC

Description of problem:
It is observed that in BRM if I copy a rule (that is in the Archive) to a valid package then it does not show up in that package. 

Whenever I attempt to view the rule via the "Browse -> Assets -> find" tab, I am able to locate the rule only when I tick the "Include archived assets in results" box.

I am not able to add a new rule using the rule name because it supposedly exists.

Version-Release number of selected component (if applicable): This issue is seen in JBoss Enterprise BRMS 5.1.0 as well as 5.2.0 


How reproducible:
It could be easily reproduced through the following steps.

Steps to Reproduce:
1. Click "Administration -> Archive" , and select any rule. 
2. Click "Actions -> Copy" to copy the rule and provide the New Name of the rule and select the New Package name where the rule would be copied to.
3. Click "Knowledge Bases -> <destination-package>" and you can not see the copied rule there.
4. Click "Knowledge Bases -> Create New -> New Rule". Now create a rule with the same name (as the name of the copied rule above), select the same package "<destination-package>" as used previously and try to create the rule. It will throw the error "An asset with that name already exists in the chosen package. Please use another name".
  
Actual results:
1. Copied rule is not listed under "Knowledge Bases -> <destination-package>"
Also, another attempt of creating a new rule with the same name is not allowed. So it means somehow the previously copied rule already exists.

Expected results:
1. The copied rule should be visible in "Knowledge Bases -> <destination-package>".

Additional info:
None

Comment 1 Rick Wagner 2012-01-30 15:08:38 UTC

GSS will try to set expectations with the customer that this issue will be fixed in an upcoming release and not via Support Patch.  Please try to include it in BRMS 5.3 if possible.

Comment 2 Tihomir Surdilovic 2012-01-30 15:19:28 UTC

I don't think this is a valid usecase. The user should unarchive their asset(s) first, and then perform the copy. Look at the archive like a trash bin on your OS, you can recover items in it, but they will be recovered back to their original location.

Comment 3 Rick Wagner 2012-01-30 15:20:51 UTC

Thanks for the note, Tiho.  We'll run this one past the customer.

Comment 4 manstis 2012-01-30 15:22:25 UTC

Flagged "devel_ack -" in light of tsurdilo's comment #2.

Comment 5 Musharraf Hussain 2012-01-31 15:17:20 UTC

Hello Tiho,

Thank you for your guidance.
But, I had a small doubt. What should be the possible use of the "copy" operation that we are providing for a BRM user which is available for any rule visible in Archive section? Since, it is copying the rules in specified package but that is not visible in the specified package in BRM.

Regards,
Musharraf Hussain

Comment 6 manstis 2012-01-31 15:41:21 UTC

IMO, we can either automatically unarchive assets that are copied, or disable the copy menu item when the asset is archived - thus leading the user to unarchive first. Personally, I don't mind.

Comment 7 manstis 2012-04-03 13:03:51 UTC

This has been addressed by JIRA GUVNOR-1365. Archived Assets should be read-only. The consequence being a read-only asset does not have a Menu bar from which you can copy the asset. So comment #2 is the only way an archived asset can be copied.

Comment 8 Ryan Zhang 2012-04-23 07:38:41 UTC

Update status to ON_QA. Please verify them against ER6.

Comment 9 Sona Mala 2012-04-24 10:56:28 UTC

I am not sure that all assets are read-only in ER6. 

1. Import empty repository.
2. Create two packages: defaultPackage, dummy

I have created new BPMN2 Process:
  3. create simple process (start event, task, terminate)
  4. save it
  5. archive
  6. open from archive manager
  7. Edit > copy to dummy.task2 ... success
  8. refresh archive manager and task2 is there
  9. open task2 add some task
  10. save and close
  11. open again task2 and changes are there
Similar usecase for Business Rules, Decision table, Rule Flow, Enumeration.

I have created new Declarative model:
  3. create new model named Model (type Fact with string field)
  4. save it
  5. archive
  6. open from archive manager
  7. you cannot modify Model, just "view source"
  8. Edit > copy to dummy.Model2 ... success
  9. refresh archive manager and Model2 is there
  10. open task2,
  11. you cannot modify Model2, just "view source"

Comment 10 manstis 2012-04-24 11:25:57 UTC

Hi, 

I don't know why this has been tested the change for GUVNOR-1365 has not been backported and both the jboss‑brms‑5.3.0 and devel_ack flags are set to "-". In short nothing has been fixed on BRMS5.3 to resolve this issue. 

If this needs to be applied please have this BZ agreed as a blocker and I will do the necessary. I have also linked a couple of other Community JIRAs for enhancements to make more editors read-only (note: BRL, Decision Table and Declarative Model already have read-only modes of operation).

With kind regards,

Mike

Comment 11 manstis 2012-05-02 12:30:56 UTC

This has been fixed in community release 5.4.

Comment 12 Ryan Zhang 2012-05-11 11:35:47 UTC

Sorry indeed, it's my mistake by setting the wrong status here.

Comment 13 lcarlon 2012-06-08 00:39:04 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Attempting to copy an archived rule creates a copy of the archived rule, however the copy is also archived and does not show up in the package it has been copied to. This workaround for this issue, is to unarchive the rule before copying. In a future release this issue will be resolved by removing the ability to copy rules that have been archived.

Comment 15 manstis 2012-08-31 09:04:33 UTC

Back-ported for 5.3.1.

Comment 16 Sona Mala 2012-10-01 14:30:37 UTC

Verified for BRMS 5.3.1 ER1

Menu disappears in archived assets.

Comment 19 JBoss JIRA Server 2014-12-19 15:19:54 UTC

Michael Anstis <michael.anstis> updated the status of jira GUVNOR-1684 to Resolved