| Summary: | Review Request: perl-Gnome2-Vte - Gnome2::Vte Perl module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Berrangé <berrange> |
| Component: | Package Review | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, rjones |
| Target Milestone: | --- | Flags: | rjones:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Gnome2-Vte-0.09-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-08 23:02:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Daniel Berrangé
2012-01-30 15:15:47 UTC
I did a F17 scratch build on x86_64 http://koji.fedoraproject.org/koji/taskinfo?taskID=3746153 There are the following rpmlint errors to be expected $ rpmlint perl-Gnome2-Vte-0.09-1.fc16.x86_64.rpm perl-Gnome2-Vte.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/Gnome2/Vte/Install/vte2perl-version.h perl-Gnome2-Vte.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/Gnome2/Vte/Install/vte2perl.h perl-Gnome2-Vte.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-Gnome2-Vte-0.09/LICENSE perl-Gnome2-Vte.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/Gnome2/Vte/Install/vte2perl-autogen.h 1 packages and 0 specfiles checked; 1 errors, 3 warnings. For the FSF address problem I filed upstream bug https://rt.cpan.org/Ticket/Display.html?id=74533 As per the Perl packaging guidelines the devel file warnings should be ignored https://fedoraproject.org/wiki/Packaging:Perl#.h_files_in_module_packages $ rpmlint perl-Gnome2-Vte-0.09-1.fc16.src.rpm perl-Gnome2-Vte.src:24: W: comparison-operator-in-deptoken font(:lang=en) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. This warning is to be expected, when following the Perl packaging guidelines https://fedoraproject.org/wiki/Perl/Tips#Tests_require_X11_server The Patch1 file has an upstream bug report too https://rt.cpan.org/Ticket/Display.html?id=74532 Taking this for review since I use this package. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3746214 + rpmlint output rpmlint output: perl-Gnome2-Vte.src:24: W: comparison-operator-in-deptoken font(:lang=en) Apparently this syntax is correct, according to the packaging guidelines. I've not seen it before. perl-Gnome2-Vte.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/Gnome2/Vte/Install/vte2perl-version.h perl-Gnome2-Vte.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/Gnome2/Vte/Install/vte2perl.h perl-Gnome2-Vte.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-Gnome2-Vte-0.09/LICENSE perl-Gnome2-Vte.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/Gnome2/Vte/Install/vte2perl-autogen.h These ones have been addressed in comment 1. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license The license file included in the package is the LGPLv2+, which is what the spec says. The source files don't reference any license at all. + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm + package successfully builds on at least one architecture + BuildRequires list all build dependencies Yes, built in Koji. n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel This is OK, see comment 1. n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file n/a packages must not own files or directories owned by other packages + filenames must be valid UTF-8 + use %global instead of %define Optional: + if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock + the package should build into binary RPMs on all supported architectures + review should test the package functions as described I have tested this with Tech Talk PSE. n/a scriptlets should be sane n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin =========================================== This package is APPROVED by rjones. =========================================== New Package SCM Request ======================= Package Name: perl-Gnome2-Vte Short Description: Perl interface to Gnome2 VTE widget Owners: berrange Branches: f16 InitialCC: perl-sig Git done (by process-git-requests). perl-Gnome2-Vte-0.09-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Gnome2-Vte-0.09-1.fc16 perl-Gnome2-Vte-0.09-1.fc16 has been pushed to the Fedora 16 testing repository. perl-Gnome2-Vte-0.09-1.fc16 has been pushed to the Fedora 16 stable repository. |