| Summary: | pigz/unpigz - what is the reason for the distribution of identical binaries? | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubos Stanek <lubek> | ||||||
| Component: | pigz | Assignee: | Adel Gadllah <adel.gadllah> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 16 | CC: | adel.gadllah, ville.skytta | ||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 2.2.5-1 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-01-17 09:53:02 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
Ok, you have built a new release without responding. I will not waste my time here. Sorry for bothering this enterprise support. (In reply to comment #1) > Ok, you have built a new release without responding. > I will not waste my time here. > Sorry for bothering this enterprise support. What kind of nonsense reaction is this? I didn't respond yet because I considered this low priority (we are talking about a few KB here ...). Also there is no "enterprise support" here ... unless you are using RHEL in that case you'd have to contact Red Hat not the Fedora maintainer. Created attachment 591530 [details]
Hardlink binaries, build with $RPM_LD_FLAGS, run test suite
Here's a patch that fixes this bug, as well as builds with $RPM_LD_FLAGS, and runs the test suite during build. Let me know if you'd like me to push and build this for devel.
Created attachment 591531 [details]
ldflags part of the patch
Thanks for the patch, looks good to me. Feel free to commit assuming access, otherwise please tell me and I will commit it. Oops, I had failed to add myself to Cc so I missed comment 5, pushed and built now for devel in 2.2.5-1. Leaving open in case you want to track or push this for earlier distro versions. This message is a reminder that Fedora 16 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 16. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '16'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 16's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 16 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged to click on "Clone This Bug" and open it against that version of Fedora. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping |
Description of problem: Files pigz and unpigz are identical. The unpigz man page is missing. Version-Release number of selected component (if applicable): pigz-2.2.3-1.fc16 Additional info: The original Makefile hardlinks the built binary: ----- Makefile snip -------- pigz: pigz.o yarn.o $(CC) -o pigz pigz.o yarn.o -lpthread -lz ln -f pigz unpigz ----- Makefile snip -------- The pigz.spec script copies identical binaries before packaging: ----- pigz.spec snip -------- %install rm -rf $RPM_BUILD_ROOT install -p -D pigz $RPM_BUILD_ROOT%{_bindir}/pigz install -p -D unpigz $RPM_BUILD_ROOT%{_bindir}/unpigz install -p -D pigz.1 -m 0644 $RPM_BUILD_ROOT%{_datadir}/man/man1/pigz.1 ----- pigz.spec snip --------