Bug 785837

Summary: Modify cumin-database to call systemctl directly instead of redirect through service
Product: [Fedora] Fedora Reporter: Trevor McKay <tmckay>
Component: cuminAssignee: Trevor McKay <tmckay>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 16CC: croberts, matt, tmckay
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 785825
: 785840 (view as bug list) Environment:
Last Closed: 2013-02-14 02:59:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 785825    
Bug Blocks: 785840, 785863    

Description Trevor McKay 2012-01-30 18:32:39 UTC
+++ This bug was initially created as a clone of Bug #785825 +++

Description of problem:

The cumin-databse script has legacy calls to /sbin/service for controlling postgresql.  This causes extra "redirecting" messages to print on the screen when script operations are run.  Eliminate these by calling systemctl.

Version-Release number of selected component (if applicable):

cumin-0.1.5137-5

How reproducible:

100%


Steps to Reproduce:
1.  yum install cumin
2.  cumin-database install
3.  cumin-database stop
4.  cumin-database start
  
Actual results:

At various points in the output from the above commands, messages like this will be printed:

Redirecting to /bin/systemctl  start postgresql.service

Expected results:

These messages should not be seen.

Additional info:

This functionality will be added through conditionals in a single script that supports F15+ and RHEL 5+.  As such, it is not just a simple cut and paste operation since platforms without systemd still need to work.

Comment 1 Trevor McKay 2012-01-31 19:55:42 UTC
Fixed in revision 5198.

Here is a test sequence that should exercise all execution paths for affected
code.  Note that users typically will likely only be doing cumin-database
install, start, and stop from the below set.

On a clean system

$ cumin-database install

This should succeed.
There should be no instances of "Redirecting to /bin/systemctl" messages in the output.  
Output should show that F16 uses "/usr/bin/postgresql-setup initdb" for database initialization.

$ cumin-database stop
$ cumin-database start 

The following steps can be done to test an execution path through the
"configure" command that will prompt the user and perform a restart.  The
"create" will leave everything in order.  Note, not strictly necessary since
users are unlikely to use these commands but to be complete...

$ cumin-database annihilate  (answer "really" at the "Really?" prompt)
$ cumin-database initialize
$ cumin-database start
$ cumin-database configure   (answer "yes" to restart)
$ cumin-database create

Comment 2 Trevor McKay 2012-01-31 20:00:20 UTC
*** Bug 785840 has been marked as a duplicate of this bug. ***

Comment 3 Fedora End Of Life 2013-01-17 02:04:02 UTC
This message is a reminder that Fedora 16 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 16. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '16'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 16's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 16 is end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" and open it against that version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Fedora End Of Life 2013-02-14 02:59:18 UTC
Fedora 16 changed to end-of-life (EOL) status on 2013-02-12. Fedora 16 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.