Bug 785944

Summary:	feh image viewer - "invalid option," segfault - fixable with a version bump
Product:	[Fedora] Fedora	Reporter:	CJ Kucera <pez>
Component:	feh	Assignee:	Ben Boeckel <fedora>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	15	CC:	fedora
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	feh-1.16.2-1.fc16	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-03-01 09:34:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description CJ Kucera 2012-01-31 00:09:56 UTC

Description of problem:

Today I ran into this bug (from feh's github tracker) - https://github.com/derf/feh/issues/49

As described there, there are various ways to construct one's ~/.config/feh/themes file such that the application doesn't read the options properly, and even segfaults.  For example, some of my runs looked like so:

$ feh foo.png 
feh: invalid option -- '�'
feh: invalid option -- '�'
feh: invalid option -- '�'
feh: invalid option -- ''

I was also able to reproduce the segfault mentioned in that bug, though I don't remember exactly how.

Version-Release number of selected component (if applicable):

feh-1.14.1-2.fc15.x86_64

How reproducible:

Every time

Steps to Reproduce:
1. Add the following line to ~/.config/feh/themes:
       feh -FdrV
2. run "feh foo.png" or "feh"
  
Actual results:
feh: invalid option -- '�'
Followed by feh ignoring the options specified in the theme file

Expected results:

Proper processing of the options in the theme file

Additional info:

There's a patch in the github bug which fixes the issue for me (I rolled my own RPM with the patch).  Additionally, it looks like the 1.x series of feh is up to 1.16.2, and this particular bug was fixed as of 1.15.  It may make more sense to just bump the version up to the latest in the 1.x series (or even hop to 2.x, of course).  It looks like F16 currently packages 1.14.1 as well, so this bug is probably present in F16 too.

Comment 1 Fedora Update System 2012-02-18 21:07:36 UTC

feh-1.16.2-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/feh-1.16.2-1.fc16

Comment 2 Fedora Update System 2012-02-19 23:17:37 UTC

Package feh-1.16.2-1.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing feh-1.16.2-1.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-2018/feh-1.16.2-1.fc16
then log in and leave karma (feedback).

Comment 3 Fedora Update System 2012-03-01 09:34:22 UTC

feh-1.16.2-1.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.