Bug 786071
| Summary: | Review Request: ghc-feldspar-language - Functional Embedded Language for DSP and PARallelism | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shakthi Kannan <shakthimaan> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DEFERRED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | haskell-devel, notting, package-review, petersen |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | NotReady | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-06-24 10:25:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 713359 | ||
|
Description
Shakthi Kannan
2012-01-31 11:05:53 UTC
Successful Koji builds for F15, F16 and F17: http://koji.fedoraproject.org/koji/taskinfo?taskID=3747890 http://koji.fedoraproject.org/koji/taskinfo?taskID=3747891 http://koji.fedoraproject.org/koji/taskinfo?taskID=3747896 $ rpmlint ghc-feldspar-language.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-feldspar-language-0.4.0.2-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-feldspar-language-0.4.0.2-1.fc15.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-feldspar-language-devel-0.4.0.2-1.fc15.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. I recommend using cabal2spec-0.25.2 now. Updated to use cabal2spec-0.25.2: SPEC: http://shakthimaan.fedorapeople.org/SPECS/ghc-feldspar-language.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/ghc-feldspar-language-0.4.0.2-2.fc15.src.rpm Successful Koji builds for F15, F16, and F17: http://koji.fedoraproject.org/koji/taskinfo?taskID=3751303 http://koji.fedoraproject.org/koji/taskinfo?taskID=3751306 http://koji.fedoraproject.org/koji/taskinfo?taskID=3751309 $ rpmlint ghc-feldspar-language.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-feldspar-language-0.4.0.2-2.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-feldspar-language-0.4.0.2-2.fc15.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-feldspar-language-devel-0.4.0.2-2.fc15.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. For reference, https://bugzilla.redhat.com/show_bug.cgi?id=612076 is the original review. You can simplify the BRs like this: -BuildRequires: ghc-QuickCheck ghc-QuickCheck-devel ghc-QuickCheck-prof -BuildRequires: ghc-random ghc-random-devel ghc -BuildRequires: ghc-mtl ghc-mtl-devel ghc-mtl-prof -BuildRequires: ghc-tagged ghc-tagged-devel -BuildRequires: ghc-type-level-devel ghc-type-level-prof +BuildRequires: ghc-QuickCheck-prof +BuildRequires: ghc-mtl-prof +BuildRequires: ghc-tagged-prof +BuildRequires: ghc-type-level-prof BR ghc-*-devel is probably good enough for F16 but F15 still has some ghc-*-prof packages left so safest to keep using ghc-*-prof until F15 is EOL and EPEL6 packages have been updated to current packaging. I think we can do this review based on pkg git since it is already there. So how about updating the master branch and then we can continue the review? > -BuildRequires: ghc-QuickCheck ghc-QuickCheck-devel ghc-QuickCheck-prof
> -BuildRequires: ghc-random ghc-random-devel ghc
> -BuildRequires: ghc-mtl ghc-mtl-devel ghc-mtl-prof
> -BuildRequires: ghc-tagged ghc-tagged-devel
> -BuildRequires: ghc-type-level-devel ghc-type-level-prof
> +BuildRequires: ghc-QuickCheck-prof
> +BuildRequires: ghc-mtl-prof
> +BuildRequires: ghc-tagged-prof
> +BuildRequires: ghc-type-level-prof
BTW I am not just nitpicking here: the package in its current
state will fail to build on secondary archs since they do not
have ghc-<libpkg> binary packages only ghc-<libpkg>-devel.
Also noting that tagged has been updated to 0.4 in f17 and f18, possible prematurely - which was not noticed since feldspar is not there now... Would be good to test if feldspar-language can be easily patched to build with tagged-0.4.*. *** Bug 713359 has been marked as a duplicate of this bug. *** Let us know when it is ready - I can come back to review this if someone doesn't beat me to it. :) A new 0.5.0.1 release is available, but, it has few dependencies that need to be packaged for Fedora. Will work on getting the dependencies available first, and will resubmit the latest package for review. Closing out old Haskell Package Reviews that use deprecated macros like %ghc_devel_package, etc, which are no longer available in F20 Rawhide. Please update your package using cabal-rpm-0.8.x or later and re-open or file a new Review Request. Thanks! |