Bug 786205

Summary:	[RFE] Enhance Audrey RPM install its own sensible modern startup code
Product:	[Retired] CloudForms Cloud Engine	Reporter:	Ian McLeod <imcleod>
Component:	aeolus-audrey-agent	Assignee:	Dan Radez <dradez>
Status:	CLOSED ERRATA	QA Contact:	dgao
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	1.0.0	CC:	asettle, dajohnso, dmacpher, gblomqui, jrd, juwu, morazi, whayutin
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	Originally Audrey started using the rc.local file. The rc.local file is deprecated. This bug fix shifted some of the content in rc.local to sysV and systemd. Audrey now has its own start-up code.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-04 14:56:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Ian McLeod 2012-01-31 17:38:22 UTC

At present, the Image Factory is expected to execute /usr/bin/audrey if it is present.  We do so by adding a single line to rc.local.

rc.local is a poor choice for startup code since it is a monolithic file (and seems to be gradually going away).

This also needlessly couples Factory and Audrey.

All parties in both the Factory and Audrey groups seem to agree that the Audrey RPM should install its own startup code going forward.

This is an RFE bug to track progress on this issue.

This is related to:

https://bugzilla.redhat.com/show_bug.cgi?id=786123

(When the Audrey feature from this bug is implemented, we can remove the code associated with that BZ.)

Comment 1 Greg Blomquist 2012-01-31 19:31:18 UTC

Thanks Ian.

Dan, we're tracking this with a redmine task now, I believe.  Can you add the redmine task link to this bug?

Comment 2 Dan Radez 2012-01-31 19:43:18 UTC

There's two, both slated for 1.1

This on removes the dep on IF
https://www.aeolusproject.org/redmine/issues/2948

this one converts the rc.local stuff to sysv/systemd
https://www.aeolusproject.org/redmine/issues/2958

Do either of these need to be expedited to be included in 1.0?

Radez

Comment 3 Greg Blomquist 2012-02-01 18:43:29 UTC

Updating version to 1.0 (found in version)

Adding cloudforms-1.1? flag (to replace original version setting)

Comment 4 Dan Radez 2012-02-07 13:47:03 UTC

Both redmine issues are completed as of commit
15b46b6c297d689a068d99ebbe1db07eb7d03749

Comment 5 jrd 2012-02-07 20:01:20 UTC

Per offline discussion, we're provisionally approving this for 1.0, pending Wes testing the bejeezus out of it.

Comment 6 James Laska 2012-02-10 14:10:00 UTC

Reassigning to proper 'aeolus-audrey-agent' component.

Comment 7 wes hayutin 2012-02-15 03:16:50 UTC

I've tested the bejeezus out of it.. but dont have the console logs to prove it..
will run through the automated tests with it one more time for the bug's sake.  Other QE do not have re-verify this bug

Comment 8 dgao 2012-02-21 20:14:34 UTC

[root@10-16-120-227 ~]# rpm -qa | grep "audrey"
aeolus-audrey-agent-0.4.4-2.el6.noarch

[root@10-16-120-227 ~]# ls /etc/init.d/audrey 
/etc/init.d/audrey

[root@10-16-120-227 ~]# cat /etc/rc.local 
#!/bin/sh
#
# This script will be executed *after* all the other init scripts.
# You can put your own initialization stuff in here if you don't
# want to do the full Sys V style init stuff.

touch /var/lock/subsys/local


[root@10-16-120-227 ~]# cat /var/log/audrey.log 
2012-02-21 15:05:04,150 - INFO    : audrey:1293 Invoked audrey_script_main
2012-02-21 15:05:04,463 - INFO    : audrey:1321 
<Instance of: CSClient
 Version: 1
 Config Server Endpoint: https://deaddonkey.usersys.redhat.com
 Config Server oAuth Key: 26712df2-5cc7-11e1-8332-0024e878a312
 Config Server oAuth Secret: BPFbhtROR0rbb6EomEEcyq6XmGDir8zezoyaZgSnucWMLYV
 Config Server Params: 
 Config Server Configs: 
 Temporary Directory: 
 Tarball Name: 
eot>
2012-02-21 15:05:04,473 - INFO    : audrey:944 Invoked
CSClient.get_cs_tooling()
2012-02-21 15:05:04,680 - INFO    : audrey:682 Invoked unpack_tooling()
2012-02-21 15:05:04,686 - INFO    : audrey:901 Invoked
CSClient.get_cs_configs()
2012-02-21 15:05:04,895 - INFO    : audrey:1356 No configuration parameters
provided. status: 202
2012-02-21 15:05:04,896 - INFO    : audrey:916 Invoked CSClient.get_cs_params()
2012-02-21 15:05:05,092 - INFO    : audrey:520 Invoked generate_provides()
2012-02-21 15:05:05,747 - INFO    : audrey:931 Invoked
CSClient.put_cs_params_values()
2012-02-21 15:05:16,047 - INFO    : audrey:901 Invoked
CSClient.get_cs_configs()
2012-02-21 15:05:16,300 - INFO    : audrey:612 Execute Tooling command:
/var/audrey/tooling/user/proxy1/start
2012-02-21 15:05:16,300 - INFO    : audrey:612 return code: 0
2012-02-21 15:05:16,301 - INFO    : audrey:612 
 Start Output of: /var/audrey/tooling/user/proxy1/start >>>

PROGNAME ***   ***   ***   ***   ***   ***
PROGNAME: /var/audrey/tooling/user/proxy1/start

pwd ***   ***   ***   ***   ***   ***
/var/audrey/tooling/user/proxy1

args ***   ***   ***   ***   ***   ***

printenv ***   ***   ***   ***   ***   ***
AUDREY_VAR_proxy1_proxy_server_1_param_1=a
AUDREY_VAR_proxy1_proxy_server_1_param_2=b
AUDREY_VAR_proxy1_proxy_server_1_param_3=10-16-120-115
AUDREY_VAR_proxy2_proxy_server_1_param_1=c
AUDREY_VAR_proxy2_proxy_server_1_param_2=d

 <<< End Output
2012-02-21 15:05:16,311 - INFO    : audrey:612 Execute Tooling command:
/var/audrey/tooling/user/proxy2/start
2012-02-21 15:05:16,311 - INFO    : audrey:612 return code: 0
2012-02-21 15:05:16,312 - INFO    : audrey:612 
 Start Output of: /var/audrey/tooling/user/proxy2/start >>>

PROGNAME ***   ***   ***   ***   ***   ***
PROGNAME: /var/audrey/tooling/user/proxy2/start

pwd ***   ***   ***   ***   ***   ***
/var/audrey/tooling/user/proxy2

args ***   ***   ***   ***   ***   ***

printenv ***   ***   ***   ***   ***   ***
AUDREY_VAR_proxy1_proxy_server_1_param_1=a
AUDREY_VAR_proxy1_proxy_server_1_param_2=b
AUDREY_VAR_proxy1_proxy_server_1_param_3=10-16-120-115
AUDREY_VAR_proxy2_proxy_server_1_param_1=c
AUDREY_VAR_proxy2_proxy_server_1_param_2=d

 <<< End Output

Comment 10 dgao 2012-09-21 19:54:59 UTC

Flipping this bug to verified based on my previous comment.

Comment 12 errata-xmlrpc 2012-12-04 14:56:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2012-1516.html