Bug 786276

Description of problem:
Twinkle crashes on incoming calls

Version-Release number of selected component (if applicable):


How reproducible:
Once it starts crashing, it simply crashes at every incoming call

Steps to Reproduce:
1. Receive an incoming call
2.
3.
  
Actual results:
Segfault (assert exception)

Expected results:


Additional info:
In src/userintf.cpp +3247 the following event is created:

void t_userintf::cb_async_display_msg(const string &msg, t_msg_priority prio) { 
        t_event_ui *event = new t_event_ui(TYPE_UI_CB_DISPLAY_MSG);
        MEMMAN_NEW(event);
        
        event->set_display_msg(msg, prio);
        evq_ui_events.push(event);
}

Events are generally caught in src/event.cpp (oid t_event_ui::exec(t_userintf *user_intf). The problem is that this event is never caught as it is not present in the switch / case set:
void t_event_ui::exec(t_userintf *user_intf) {
        switch (type) {
        case TYPE_UI_CB_DTMF_DETECTED:
                ui->cb_dtmf_detected(line, dtmf_event);
                break;
        case TYPE_UI_CB_SEND_DTMF:
                ui->cb_send_dtmf(line, dtmf_event);
                break;
        case TYPE_UI_CB_RECV_CODEC_CHANGED:
                ui->cb_recv_codec_changed(line, codec);
                break;
        case TYPE_UI_CB_LINE_STATE_CHANGED:
                ui->cb_line_state_changed();
                break;
        case TYPE_UI_CB_LINE_ENCRYPTED:
                ui->cb_line_encrypted(line, encrypted, cipher_mode);
                break;
        case TYPE_UI_CB_SHOW_ZRTP_SAS:
                ui->cb_show_zrtp_sas(line, zrtp_sas);
                break;
        case TYPE_UI_CB_ZRTP_CONFIRM_GO_CLEAR:
                ui->cb_zrtp_confirm_go_clear(line);
                break;
        case TYPE_UI_CB_QUIT:
                ui->cmd_quit();
                break;
        default:
                assert(false);
        }
}

As TYPE_UI_CB_DISPLAY_MSG is missing there we will hit assert.

Patch attached.

RH colleague of mine (luvilla) also confirmed this fixes this for him

cheers,
Michele