Bug 786386

Summary: vdsm-bootstrap: SetNetworking failure doesn't influence the vdsm-bootstrap final status
Product: [Retired] oVirt Reporter: Avi Tal <atal>
Component: vdsmAssignee: Dan Kenigsberg <danken>
Status: CLOSED NOTABUG QA Contact: Yaniv Kaul <ykaul>
Severity: medium Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: abaron, acathrow, alonbl, bazulay, dougsland, iheim, jkt, mavital, srevivo, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: network
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-09-25 07:44:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
vdsm-bootstrap log none

Description Avi Tal 2012-02-01 10:16:46 UTC 
Created attachment 558785 [details]
vdsm-bootstrap log

Description of problem:
vdsm-bootstrap final status will be OK even though it failed to configure network.

following a relevant vdsm-bootstrap.log:
Wed, 01 Feb 2012 09:07:50 DEBUG    makeBridge return.
Wed, 01 Feb 2012 09:07:50 ERROR    addNetwork error trying to add management bridge
Wed, 01 Feb 2012 09:07:50 DEBUG    <BSTRAP component='SetNetworking' status='FAIL' message='addNetwork error trying to add management bridge'/>
.
.
.
Wed, 01 Feb 2012 11:05:16 DEBUG    <BSTRAP component='RHEV_INSTALL' status='OK'/>
Comment 1 Avi Tal 2012-02-01 10:19:30 UTC 
In that specific case the reason for the failure was, already existing bridge over eth0 but that bridge wasn't "ovirtmgmt" there for after reboot the host will become non-operational.
Comment 2 Dan Kenigsberg 2012-09-25 07:44:54 UTC 
This behavior was intentional:

    def setNetworking(self, iurl):
        """
            Create management bridge.
            This class will try to create a management bridge named "rehvm". Class
            always succeeds to allow network configuration from managment server
            even in case this class will fail to set the management bridge.


however, it is going to be reconsidered by Alon when he re-writes bootstrapping soon.