Bug 786594

Summary: Review Request: beefy-miracle-backgrounds - Beefy Miracle desktop backgrounds
Product: [Fedora] Fedora Reporter: Martin Sourada <martin.sourada>
Component: Package ReviewAssignee: Matthias Runge <mrunge>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jreznik, mrunge, notting, package-review, susi.lehtola
Target Milestone: ---Flags: mrunge: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-06 21:49:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Martin Sourada 2012-02-01 21:02:38 UTC 
Spec URL: http://mso.fedorapeople.org/packages/SPECS/beefy-miracle-backgrounds.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/beefy-miracle-backgrounds-16.91.0-1.fc16.src.rpm
Description: This package contains the desktop backgrounds for the Beefy Miracle theme.

Additional info: spec reused from previous releases, dangling symlinks are OK.
Comment 1 Matthias Runge 2012-02-02 09:09:28 UTC 
just some small notes: 

version and latest changelog version do not match.

You may drop buildroot definition.
Comment 2 Susi Lehtola 2012-02-02 10:12:57 UTC 
And you can drop the License field in the -single package, since it's the same as in the main package.
Comment 3 Jaroslav Reznik 2012-02-02 11:43:12 UTC 
Anybody taking the review officially guys? I can do it.
Comment 4 Matthias Runge 2012-02-02 12:04:38 UTC 
Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[X]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
     Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: defattr(....) present in %files kde section. This is OK if
     packaging for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[!]: MUST Package contains a properly installed %{name}.desktop using desktop-
     file-install file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint beefy-miracle-backgrounds-kde-16.91.0-1.fc17.noarch.rpm

beefy-miracle-backgrounds-kde.noarch: W: no-documentation
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1920x1200.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1024x600.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1280x1024.png ../../../../backgrounds/beefy-miracle/default/normalish/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1920x1080.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/640x480.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1280x960.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1600x1280.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1600x1200.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/800x480.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1440x900.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1200x900.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1366x768.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1680x1050.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1920x1440.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1024x768.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1280x800.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/2048x1536.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1152x864.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1440x1080.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1152x720.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1280x720.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/800x600.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1280x768.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
1 packages and 0 specfiles checked; 0 errors, 24 warnings.


rpmlint beefy-miracle-backgrounds-16.91.0-1.fc17.src.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint beefy-miracle-backgrounds-single-16.91.0-1.fc17.noarch.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint beefy-miracle-backgrounds-gnome-16.91.0-1.fc17.noarch.rpm

beefy-miracle-backgrounds-gnome.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


rpmlint beefy-miracle-backgrounds-16.91.0-1.fc17.noarch.rpm

beefy-miracle-backgrounds.noarch: W: incoherent-version-in-changelog 16.90.1-1 ['16.91.0-1.fc17', '16.91.0-1']
beefy-miracle-backgrounds.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


rpmlint beefy-miracle-backgrounds-xfce-16.91.0-1.fc17.noarch.rpm

beefy-miracle-backgrounds-xfce.noarch: W: no-documentation
beefy-miracle-backgrounds-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/beefy-miracle.png ../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/mrunge/786594/beefy-miracle-backgrounds-16.91.0.tar.xz :
  MD5SUM this package     : b6c129aaee8deeae9bd426bfa91cb712
  MD5SUM upstream package : b6c129aaee8deeae9bd426bfa91cb712

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Buildroot is not present
     Note: Buildroot is not needed unless packager plans to package for EPEL5
[!]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: defattr(....) present in %files kde section. This is OK if
     packaging for EPEL5. Otherwise not needed
[!]: MUST Package contains a properly installed %{name}.desktop using desktop-
     file-install file if it is a GUI application.
[!]: MUST Rpmlint output is silent.

rpmlint beefy-miracle-backgrounds-kde-16.91.0-1.fc17.noarch.rpm

beefy-miracle-backgrounds-kde.noarch: W: no-documentation
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1920x1200.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1024x600.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1280x1024.png ../../../../backgrounds/beefy-miracle/default/normalish/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1920x1080.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/640x480.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1280x960.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1600x1280.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1600x1200.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/800x480.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1440x900.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1200x900.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1366x768.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1680x1050.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1920x1440.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1024x768.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1280x800.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/2048x1536.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1152x864.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1440x1080.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1152x720.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1280x720.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/800x600.png ../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/Beefy_Miracle/contents/images/1280x768.png ../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
1 packages and 0 specfiles checked; 0 errors, 24 warnings.


rpmlint beefy-miracle-backgrounds-16.91.0-1.fc17.src.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint beefy-miracle-backgrounds-single-16.91.0-1.fc17.noarch.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint beefy-miracle-backgrounds-gnome-16.91.0-1.fc17.noarch.rpm

beefy-miracle-backgrounds-gnome.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


rpmlint beefy-miracle-backgrounds-16.91.0-1.fc17.noarch.rpm

beefy-miracle-backgrounds.noarch: W: incoherent-version-in-changelog 16.90.1-1 ['16.91.0-1.fc17', '16.91.0-1']
beefy-miracle-backgrounds.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


rpmlint beefy-miracle-backgrounds-xfce-16.91.0-1.fc17.noarch.rpm

beefy-miracle-backgrounds-xfce.noarch: W: no-documentation
beefy-miracle-backgrounds-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/beefy-miracle.png ../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
1 packages and 0 specfiles checked; 0 errors, 2 warnings.




Generated by fedora-review 0.1.2
Comment 5 Matthias Runge 2012-02-02 12:07:29 UTC 
I'd approve this review, if above issues are fixed; I'd just ignore those rpmlint warnings.

If any of you guys is willing to approve this anyway, please step up!
Comment 6 Martin Sourada 2012-02-02 15:41:50 UTC 
(In reply to comment #4)
> Package Review
> ==============
> Issues:
> [!]: MUST Buildroot is not present
>      Note: Buildroot is not needed unless packager plans to package for EPEL5
> [!]: MUST Each %files section contains %defattr if rpm < 4.4
>      Note: defattr(....) present in %files kde section. This is OK if
>      packaging for EPEL5. Otherwise not needed
As I understand the guidelines it is not a requirement to not include buildroot and defattr, but I can remove them if you insist.

> [!]: MUST Package contains a properly installed %{name}.desktop using desktop-
>      file-install file if it is a GUI application.
It's not a GUI application.

> [!]: MUST Rpmlint output is silent.
> 
The no-doc and dangling symlink warnings are actually satisfied by deps.

> beefy-miracle-backgrounds.noarch: W: incoherent-version-in-changelog 16.90.1-1
> ['16.91.0-1.fc17', '16.91.0-1']
This is a typo and I'll fix it when I get home.

Hope I didn't missed anything.
Comment 7 Martin Sourada 2012-02-06 16:09:46 UTC 
Buildroot and defattr removed, typo fixed.

New SRPM: http://mso.fedorapeople.org/packages/SRPMS/beefy-miracle-backgrounds-16.91.0-2.fc16.src.rpm
New SPEC: http://mso.fedorapeople.org/packages/SPECS/beefy-miracle-backgrounds.spec
Comment 8 Martin Sourada 2012-02-06 16:10:36 UTC 
Oh, and apology for the lateness -- I was ill.
Comment 9 Matthias Runge 2012-02-06 17:53:25 UTC 
Hope you're feeling better now.

Package is APPROVED.
Comment 10 Martin Sourada 2012-02-06 18:02:21 UTC 
New Package SCM Request
=======================
Package Name: beefy-miracle-backgrounds
Short Description: Beefy Miracle desktop backgrounds 
Owners: mso
Branches: 
InitialCC:
Comment 11 Gwyn Ciesla 2012-02-06 18:52:22 UTC 
Git done (by process-git-requests).
Comment 12 Martin Sourada 2012-02-06 21:49:04 UTC 
(In reply to comment #9)
> Hope you're feeling better now.
> 
Yes, thank you.

> Package is APPROVED.
Thanks for the review.