Bug 786611

Summary: drift diff is different depending on order in which files are selected
Product: [Other] RHQ Project Reporter: Charles Crouch <ccrouch>
Component: Core UIAssignee: Jay Shaughnessy <jshaughn>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.2CC: hbrock, hrupp, jshaughn, mazz, skondkar, spinder
Target Milestone: ---   
Target Release: JON 3.0.1   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 765592 Environment:
Last Closed: 2013-09-03 15:02:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 760116, 765592    
Bug Blocks: 707225, 782579    

Description Charles Crouch 2012-02-01 22:07:24 UTC
+++ This bug was initially created as a clone of Bug #765592 +++

go to carousel. say I have snapshot 2 and snapshot 1 that both show drift for file "foo.txt".

select foo.txt in snapshot 2, then select foo.txt in snapshot 1. then "compare" and you see the diff

now deselect everything and now select the files in reverse order (select the one in SS 1, then in SS 2) and do "compare" and notice the diff represents the opposite

that is, for example, the lines that were DELETED in the first compare are now ADDED in the second compare because I changed the order of the files.

We want to compare the oldest as "first" and the newest as "second", always

--- Additional comment from jshaughn on 2011-12-09 14:46:38 EST ---

master commit 5938a790c0aeb32865f4b115e721de22220ca100

Fixed, the new changes will now always get the "+" prefixes and the older
will get the "-" prefixes.

--- Additional comment from mfoley on 2011-12-12 10:31:39 EST ---

verified RHQ 4.3 master branch

Comment 3 Simeon Pinder 2012-02-09 20:03:55 UTC
Moving this to ON_QA as new RC3 binary available here:
https://brewweb.devel.redhat.com//buildinfo?buildID=198086

Comment 4 Sunil Kondkar 2012-02-10 11:27:37 UTC
Verified on Version: 3.0.1.GA RC3 build. (Build Number: dd8a001:0ba18fd)

Compared the drift diff by changing the order of file selection. Verified that New changes have "+" prefixes and the older have "-" prefixes.

Comment 5 Heiko W. Rupp 2013-09-03 15:02:03 UTC
Bulk closing of old issues in VERIFIED state.