Bug 786693

Summary: Fix recently identified races within the autofs kernel wait code
Product: Red Hat Enterprise Linux 6 Reporter: Ian Kent <ikent>
Component: kernelAssignee: Ian Kent <ikent>
Status: CLOSED ERRATA QA Contact: yanfu,wang <yanwang>
Severity: high Docs Contact:
Priority: high    
Version: 6.2CC: aviro, dhowells, jlayton, jmoyer, rwheeler, yanwang
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: kernel-2.6.32-238.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-20 08:21:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 773127    
Attachments:
Description Flags
Patch - autofs4: deal with autofs4_write/autofs4_write races
none
Patch - autofs4: catatonic_mode vs. notify_daemon race
none
Patch - autofs4: autofs4_wait() vs. autofs4_catatonic_mode() race none

Description Ian Kent 2012-02-02 07:20:13 UTC
Description of problem:

During a recent discussion with Al Viro he identified a couple
of problems with the autofs kernel module wait code. As a result
three patches are now in the 3.3-rc kernel.

These patches are worth including in our RHEL kernel in their
own right but, coincidentally,  we may have a customer that is
seeing an example of this bug (rhbz#773127)

Comment 1 Ian Kent 2012-02-02 07:26:43 UTC
Created attachment 558993 [details]
Patch - autofs4: deal with autofs4_write/autofs4_write races

Comment 2 Ian Kent 2012-02-02 07:27:41 UTC
Created attachment 558994 [details]
Patch - autofs4: catatonic_mode vs. notify_daemon race

Comment 3 Ian Kent 2012-02-02 07:28:40 UTC
Created attachment 558995 [details]
Patch - autofs4: autofs4_wait() vs. autofs4_catatonic_mode() race

Comment 4 RHEL Program Management 2012-02-02 07:29:10 UTC
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.

Comment 5 Aristeu Rozanski 2012-02-24 21:55:58 UTC
Patch(es) available on kernel-2.6.32-238.el6

Comment 18 yanfu,wang 2012-03-20 06:32:56 UTC
run autofs connectation and submount test as per comment #9, result passed.
autofs connectation:
All tests completed

Test Summary:
parser - PASSED.
test1 - PASSED.
test2 - PASSED.
test3 - PASSED.
test4 - PASSED.
test5 - PASSED.
badnames - PASSED.
trailing_space - PASSED.

submount-test passed:
https://beaker.engineering.redhat.com/jobs/200914
https://beaker.engineering.redhat.com/jobs/200913
https://beaker.engineering.redhat.com/jobs/200910
https://beaker.engineering.redhat.com/jobs/200909

And I will run autofs regression test suite later since some changed against it,
I will give comment when I done.

Comment 20 yanfu,wang 2012-04-16 04:39:50 UTC
autofs regression test results shown as below:
autofs regression on old package autofs-5.0.5-39.el6_2.1:
https://beaker.engineering.redhat.com/jobs/201338
https://beaker.engineering.redhat.com/jobs/201339
https://beaker.engineering.redhat.com/jobs/201340
https://beaker.engineering.redhat.com/jobs/201341

autofs regression on new package:
x86_64: https://beaker.engineering.redhat.com/jobs/212456, For failed bz212249 on client, re-submit https://beaker.engineering.redhat.com/jobs/215181, passed
ppc64: https://beaker.engineering.redhat.com/jobs/212455;
s390x: https://beaker.engineering.redhat.com/jobs/212247; For failed bz130467 on client caused by no server is on the same subnet as the client.
i386: https://beaker.engineering.redhat.com/jobs/215176
For failed bz346091 on server, pls check comment https://bugzilla.redhat.com/show_bug.cgi?id=787595#c21. These rpc null procedure calls for checking server availability added back by developer to check for simple mounts to avoid calling mount.nfs when the server isn't available.

And the autofs connectation and submount test results pls refer to comment #18.
Patches of comment #6 are applied well.
So setting the bug as SanityOnly now.

Comment 22 errata-xmlrpc 2012-06-20 08:21:20 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0862.html