Bug 786800

Summary: Failing tests due to improper VCR cassete content
Product: [Retired] CloudForms Cloud Engine Reporter: Petr Blaho <pblaho>
Component: rubygem-aeolus-cliAssignee: Petr Blaho <pblaho>
Status: CLOSED CURRENTRELEASE QA Contact: pushpesh sharma <psharma>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.0.0CC: bbandari, dajohnso, slinaber, whayutin
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-30 17:12:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Petr Blaho 2012-02-02 12:14:15 UTC 
Description of problem:

There are 2 tests that fails after mzatko's patch for https://bugzilla.redhat.com/show_bug.cgi?id=747719

There are bad contents of VCR cassetes for 2 tests.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. rake spec
2.
3.
  
Actual results:

Failures:

  1) Aeolus::CLI::DeleteCommand Delete Failed Not Found should display an appropriate message when the given image is not found
     Failure/Error: $stdout.string.should include("Could not find Image 1234")
       expected "\nERROR:  Service Temporarily Unavailable => Please check that Conductor is running.\n" to include "Could not find Image 1234"
       Diff:
       @@ -1,2 +1,3 @@
       -Could not find Image 1234
       +
       +ERROR:  Service Temporarily Unavailable => Please check that Conductor is running.
     # ./spec/command/delete_command_spec.rb:86
     # ./spec/command/delete_command_spec.rb:78

  2) Aeolus::CLI::DeleteCommand Delete Failed Not Found should display an appropriate message when the given target image is not found
     Failure/Error: $stdout.string.should include("Could not find TargetImage 1234")
       expected "\nERROR:  Service Temporarily Unavailable => Please check that Conductor is running.\n" to include "Could not find TargetImage 1234"
       Diff:
       @@ -1,2 +1,3 @@
       -Could not find TargetImage 1234
       +
       +ERROR:  Service Temporarily Unavailable => Please check that Conductor is running.
     # ./spec/command/delete_command_spec.rb:112
     # ./spec/command/delete_command_spec.rb:104

Finished in 1.74 seconds
80 examples, 2 failures

Failed examples:

rspec ./spec/command/delete_command_spec.rb:77 # Aeolus::CLI::DeleteCommand Delete Failed Not Found should display an appropriate message when the given image is not found
rspec ./spec/command/delete_command_spec.rb:103 # Aeolus::CLI::DeleteCommand Delete Failed Not Found should display an appropriate message when the given target image is not found


Expected results:

Tests should pass.

Additional info:

Code and tests are OK, VCR did not reflect actual response from conductor API.
Comment 1 Petr Blaho 2012-02-02 12:19:18 UTC 
I accidentally pointed to bad BZ in first comment.

Tests fails after mzatko's match for https://bugzilla.redhat.com/show_bug.cgi?id=749376
Comment 2 Petr Blaho 2012-02-02 15:13:28 UTC 
Posted here:

https://fedorahosted.org/pipermail/aeolus-devel/2012-February/008576.html
Comment 3 Petr Blaho 2012-02-06 14:57:27 UTC 
commit 2a34282137ffbbd9a5df8b0d10b3cb61fd2803b8
Author: Petr Blaho <pblaho>
Date:   Thu Feb 2 13:15:57 2012 +0100

    BZ786800 Correct VCR cassetes for delete command
    
    https://bugzilla.redhat.com/show_bug.cgi?id=786800
    
    This corrects content of VCR cassetes for delete image and delete target image commands
    
    There is now correct http status and body from conductor response for attempt of deleting non existent image/target image.
Comment 4 Steve Linabery 2012-02-14 18:53:33 UTC 
2a34282 in rubygem-aeolus-cli-0.3.0-8
Comment 5 wes hayutin 2012-02-27 21:23:03 UTC 
failing this until all spec tests are passing :P
http://hudson.rhq.lab.eng.bos.redhat.com:8080/hudson/view/QE-CloudForms-CloudEngine/job/aeolus-conductor-spec/34/consoleFull
Comment 6 Petr Blaho 2012-02-28 10:05:12 UTC 
These tests fails from introducing solution for https://bugzilla.redhat.com/show_bug.cgi?id=796783

It works only with aeolus-image-rubygem built from source atm.

I have spent a huge amount of time to discover this yesterday.
Comment 8 Dave Johnson 2012-03-16 18:37:10 UTC 
Tests here look good...

http://hudson.rhq.lab.eng.bos.redhat.com:8080/hudson/view/QE-CloudForms-CloudEngine/job/aeolus-conductor-spec/90/console
Comment 9 wes hayutin 2012-03-30 19:02:00 UTC 
assigning to Pushpesh
Comment 10 pushpesh sharma 2012-04-05 09:48:34 UTC 
Verified as follows:-

[root@qe-blade-01 ~]# aeolus-image delete -I 6a956e96-7eee-11e1-8855-00215e20316a
Image: 6a956e96-7eee-11e1-8855-00215e20316a Deleted Successfully

N.B. The following provider content must be manually removed

Provider               ID               
------------------     ------------     
ec2-ap-southeast-1     ami-56763104     
[root@qe-blade-01 ~]# aeolus-image delete -I 6a956e96-7eee-11e1-8855-00215e20316a

ERROR:  ImageNotFound => Could not find Image 6a956e96-7eee-11e1-8855-00215e20316a
[root@qe-blade-01 ~]# service aeolus-conductor stop
Shutting down thin: [  OK  ]
[root@qe-blade-01 ~]# aeolus-image delete -I 6a956e96-7eee-11e1-8855-00215e20316a

ERROR:  Service Temporarily Unavailable => Please check that Conductor is running.


all error messages are coherent.Marking this bug as verified.
Comment 11 wes hayutin 2012-04-05 13:40:14 UTC 
spec tests currently runs w/o error
http://hudson.rhq.lab.eng.bos.redhat.com:8080/hudson/view/QE-CloudForms-CloudEngine/job/aeolus-conductor-spec/110/console

Finished in 864.47 seconds
698 examples, 0 failures
No emails were triggered.