Bug 786816

Summary: fedpkg update crashes
Product: [Fedora] Fedora Reporter: Orcan Ogetbil <oget.fedora>
Component: bodhiAssignee: Luke Macken <lmacken>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: a.badger, lmacken, pfrields, tla
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-02 14:29:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Orcan Ogetbil 2012-02-02 13:35:42 UTC
Hi Luke, I am using bodhi-client-0.8.5-1.fc16. I tried to file an update with the command line client. I got:


~/vcs/fedora-git/sha2 (f15) $ fedpkg update
Traceback (most recent call last):
  File "/usr/bin/bodhi", line 519, in <module>
    main()
  File "/usr/bin/bodhi", line 201, in main
    updates = bodhi.parse_file(input_file=opts.input_file)
  File "/usr/lib/python2.7/site-packages/fedora/client/bodhi.py", line 281, in parse_file
    config.readfp(template_file)
  File "/usr/lib/python2.7/site-packages/iniparse/compat.py", line 111, in readfp
    self.data._readfp(fp)
  File "/usr/lib/python2.7/site-packages/iniparse/ini.py", line 641, in _readfp
    raise exc
ConfigParser.ParsingError: File contains parsing errors: bodhi.template
        [line 14]: interface is similar to the interface to SHA-1 found in the OpenSSL library.

        [line 16]: sha2 is a simple program that accepts input from either STDIN or reads one or

        [line 17]: more files specified on the command line, and then generates the specified hash

        [line 18]: (either SHA-256, SHA-384, SHA-512, or any combination thereof, including all

        [line 19]: three at once).

Could not generate update request: Command 'bodhi --new --release f15 --file bodhi.template sha2-1.0.1-1.fc15 --username oget' returned non-zero exit status 1
~/vcs/fedora-git/sha2 (f15) $




The update template was filled as follows:



[ sha2-1.0.1-1.fc15 ]

# bugfix, security, enhancement, newpackage (required)
type=newpackage

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=782178

# Description of your update
notes=The library implements the SHA-256, SHA-384, and SHA-512 hash algorithms. The
interface is similar to the interface to SHA-1 found in the OpenSSL library.

sha2 is a simple program that accepts input from either STDIN or reads one or
more files specified on the command line, and then generates the specified hash
(either SHA-256, SHA-384, SHA-512, or any combination thereof, including all
three at once).

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

Comment 1 Luke Macken 2012-02-02 14:29:00 UTC
This issue is due to the newlines in the notes.

At the moment your best bet is to submit the update either with all of the notes on one line (or using the multi-line technique that is shown in the default template), or edit the notes after the update is initially created.

We're aware that this is a pain, and will hopefully address it in Bodhi v2.0.