Bug 786849

Summary: False results for Test::Pod and Test::Pod::Coverage since F17 mass rebuild
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: perl-Module-ExtractUseAssignee: Daniel Berrangé <berrange>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: berrange, mmaslano, paul, perl-devel, ppisar, psabata, tremble
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-04 10:22:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Difference in build roots none

Description Petr Pisar 2012-02-02 14:55:47 UTC 
perl-RT-Client-REST-0.37-9.fc17 uses Test::Kwalittee in tests. The tests passed on F17 mass rebuild (https://koji.fedoraproject.org/koji/buildinfo?buildID=289727).

Now, the tests fail:

#   Failed test 'has_test_pod'
#   at /usr/share/perl5/vendor_perl/Test/Kwalitee.pm line 101.
# Add a test using Test::Pod to check for pod correctness.Doesn't include a test for pod correctness (Test::Pod)

#   Failed test 'has_test_pod_coverage'
#   at /usr/share/perl5/vendor_perl/Test/Kwalitee.pm line 101.
# Add a test using Test::Pod::Coverage to check for POD coverage.Doesn't include a test for pod coverage (Test::Pod::Coverage)
# Looks like you failed 2 tests of 13.
t/99-kwalitee.t ......
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/13 subtests

I discovered it when upgrading perl-RT-CLient-REST, but I can reproduce it with the old srpm (based on perl-RT-CLient-REST commit a69804d94e1c69815f708b1abeb6a5d3525b91cc).

Also it passes in F16.

I cannot say whether this is bug in perl-Test-Kwalitee (versions of Test::Kwalitee and Module::CPANTS::Analyse did not changed:perl-Test-Kwalitee-1.01-11.fc17, perl-Module-CPANTS-Analyse-0.85-10.fc17).

There is suspicious report on upstream site (https://rt.cpan.org/Public/Bug/Display.html?id=24504).
Comment 1 Petr Pisar 2012-02-02 14:59:10 UTC 
Created attachment 559068 [details]
Difference in build roots

The old build root passes, the new one does not. I know the list is long, but I have no better clue now.
Comment 2 Paul Howarth 2012-02-02 18:33:55 UTC 
This is due to an incompatible change in Parse::RecDescent that has broken Module::ExtractUse (https://rt.cpan.org/Public/Bug/Display.html?id=74608).

It can be fixed by recompiling the grammar in %prep:

# Recompile the grammar to work with the new Parse::RecDescent (CPAN RT#74608)
cd lib/Module/ExtractUse
rm Grammar.pm
perl -MParse::RecDescent - grammar Module::ExtractUse::Grammar
cd -

I have verified that this change fixes the build of both perl-Module-ExtractUse and perl-RT-Client-REST.

I am happy to do this change and build it if the perl-Module-ExtractUse maintainer is busy.
Comment 3 Daniel Berrangé 2012-02-04 10:22:10 UTC 
Built perl-Module-ExtractUse-0.23-11.fc17 into F17 rawhide.
Comment 4 Petr Pisar 2012-02-06 09:14:46 UTC 
Thanks. perl-RT-Client-REST has been rebuilt withTest::Kwalitee as 0.43-2.fc17 successfully.