Bug 787116

Summary:	radtest PPPhint option is not parsed properly
Product:	Red Hat Enterprise Linux 6	Reporter:	Karel Srot <ksrot>
Component:	freeradius	Assignee:	John Dennis <jdennis>
Status:	CLOSED ERRATA	QA Contact:	Patrik Kis <pkis>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.2	CC:	dpal, pkis
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	freeradius-2.1.12-1.el6	Doc Type:	Bug Fix
Doc Text:	Cause: radtest does not recognize documented PPPhint command line option when non-zero. Consequence: radtest fails if a non-zero PPPhint command line option provided because it applies the wrong command line arguments. Fix: Modify radtest to recognize an integer command line argument instead of testing if the next arg is zero. Result: The command line arguments are properly applied.	Story Points:	---
Clone Of:	760193
Clones:	1047859 (view as bug list)		Environment:
Last Closed:	2012-06-20 14:06:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1047859

Description Karel Srot 2012-02-03 08:11:41 UTC

also present in freeradius-2.1.10-5.el6

+++ This bug was initially created as a clone of Bug #760193 +++

Description of problem:
i:x86_64|m:x86_64 root@ibm-ls41-02 [~]# man radtest | grep -A3 ppphint
       ppphint
              If  you put an integer > 0 here, radtest (or actually radclient)
              will add the attribute Framed-Protocol  =  PPP  to  the  request
              packet.
i:x86_64|m:x86_64 root@ibm-ls41-02 [~]# /usr/bin/radtest --help
Usage: radtest [OPTIONS] user passwd radius-server[:port] nas-port-number secret [ppphint] [nasname]
        -d RADIUS_DIR       Set radius directory
        -t <type>           Set authentication method
                            type can be pap, chap, mschap, or eap-md5
        -x                  Enable debug output
        -4                  Use IPv4 for the NAS address (default)
        -6                  Use IPv6 for the NAS address
i:x86_64|m:x86_64 root@ibm-ls41-02 [~]# /usr/bin/radtest -x -4 testuser RedHat localhost:1812 1812 RedHat 0 localhost
Sending Access-Request of id 149 to 127.0.0.1 port 1812
	User-Name = "testuser"
	User-Password = "RedHat"
	NAS-IP-Address = 127.0.0.1
	NAS-Port = 1812
	Message-Authenticator = 0x00000000000000000000000000000000
	Framed-Protocol = PPP
Sending Access-Request of id 149 to 127.0.0.1 port 1812
	User-Name = "testuser"
	User-Password = "RedHat"
	NAS-IP-Address = 127.0.0.1
	NAS-Port = 1812
	Message-Authenticator = 0x00000000000000000000000000000000
	Framed-Protocol = PPP
Sending Access-Request of id 149 to 127.0.0.1 port 1812
	User-Name = "testuser"
	User-Password = "RedHat"
	NAS-IP-Address = 127.0.0.1
	NAS-Port = 1812
	Message-Authenticator = 0x00000000000000000000000000000000
	Framed-Protocol = PPP
radclient: no response from server for ID 149 socket 3
i:x86_64|m:x86_64 root@ibm-ls41-02 [~]# grep '$6' /usr/bin/radtest
	if [ "$6" ]


Version-Release number of selected component (if applicable):
freeradius2-2.1.12-2.el5
freeradius2-utils-2.1.12-2.el5

How reproducible:
Always

Steps to Reproduce:
1. run command: /usr/bin/radtest -x -4 testuser RedHat localhost:1812 1812 RedHat 0 localhost | grep -q "PPP" && echo FAIL || echo PASS
and wait a few seconds
  
Actual results:
FAIL

Expected results:
PASS

Additional info:

Comment 6 John Dennis 2012-04-24 17:05:48 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause:

radtest does not recognize documented PPPhint command line option when non-zero.

Consequence:

radtest fails if a non-zero PPPhint command line option provided because it applies the wrong command line arguments.

Fix:

Modify radtest to recognize an integer command line argument instead of testing if the next arg is zero.

Result:

The command line arguments are properly applied.

Comment 8 errata-xmlrpc 2012-06-20 14:06:12 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0881.html