Bug 787226

Summary:	Environment renaming should be disabled
Product:	Red Hat Satellite	Reporter:	Justin Sherrill <jsherril>
Component:	API	Assignee:	Tom McKay <tomckay>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Garik Khachikyan <gkhachik>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.0.0	CC:	gkhachik, inecas, mkoci, tomckay
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-22 18:24:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Justin Sherrill 2012-02-03 15:55:28 UTC

Since we base the repoid in pulp off of the environment name, we really shouldn't be able to rename it, as it could cause problems. 

One such scenario that could cause issues:


1. create environment Dev
2. promote repo X to dev
3. rename environment Dev to Foo
4. Create a new environment called Dev after Foo
5. promote repo X to Dev


Since the repo was already created in an environment called Dev, the repo promotion would fail.  


Ideally we wouldn't be basing repo_id off of environment name.  There was some discussion on having an immutable label field, which should allow us to have a name that is changeable, but this is probably post V1.


We need to block this in the UI and the api.

Comment 1 Ivan Necas 2012-02-21 10:21:16 UTC

Update on model level and removed from CLI in commit fad3a89dd63471a3b233097079a2e709c208d9a2

Comment 3 Ivan Necas 2012-02-21 10:24:50 UTC

Since the preventing of name update is achieved by validation, and so this change also affected UI (user gets descriptive error message after trying to update the environment name), the possibility to update it in UI should be fully removed from the UI.

@justin could you take care of it?, thx

Comment 4 Tom McKay 2012-02-21 19:38:30 UTC

Disabling edit from UI.

Comment 5 Tom McKay 2012-02-21 20:04:54 UTC

commit 94e403f15a3dcbf99ebec6dae5e7a3466d66eb09
Author: Tom McKay <thomasmckay>
Date:   Tue Feb 21 15:04:30 2012 -0500

    787226 - removed 'editable' form env name form field

Comment 7 Garik Khachikyan 2012-02-22 15:10:51 UTC

# VERIFIED

both API and CLI have disabled with environment name rename option.

checked:
---
katello-0.1.243-1.git.0.a066880.el6.noarch
katello-cli-0.1.57-1.git.0.4e2dd9a.el6.noarch
pulp-0.0.266-1.el6.noarch
candlepin-0.5.20-1.el6.noarch
---