Bug 787250

Summary:	[rhq-agent-env.sh/bat] --daemon should not be in example value for RHQ_AGENT_CMDLINE_OPTS and comment should be added saying --daemon should generally not be included in RHQ_AGENT_CMDLINE_OPTS
Product:	[Other] RHQ Project	Reporter:	Ian Springer <ian.springer>
Component:	Agent	Assignee:	Ian Springer <ian.springer>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.2	CC:	ccrouch, hrupp
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-07 19:24:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Ian Springer 2012-02-03 17:04:53 UTC

Due to the fact that rhq-agent-env.sh is used by both
rhq-agent-wrapper.sh and rhq-agent.sh, users should never include --daemon when
setting RHQ_AGENT_CMDLINE_OPTS in rhq-agent-env.sh. Including it there would cause the Agent to always start in daemon mode, even when started via rhq-agent.sh, which generally wouldn't make sense, since rhq-agent-wrapper.sh is the recommended way to start the Agent as a daemon.

We should remove it from the commented out "#RHQ_AGENT_CMDLINE_OPTS=" line in the default rhq-agent-env.sh and add a comment telling users to never include --daemon in the value.

Comment 1 Ian Springer 2012-02-03 19:07:19 UTC

This is done in master - http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commitdiff;h=0ed38f2

Comment 2 Mike Foley 2012-02-07 19:24:10 UTC

changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE